feat: Walk phase - observability, scanning, contract tests, and CI improvements#203
Closed
sanghinitin wants to merge 3 commits into
Closed
feat: Walk phase - observability, scanning, contract tests, and CI improvements#203sanghinitin wants to merge 3 commits into
sanghinitin wants to merge 3 commits into
Conversation
…provements - Add emit_operation_metric structured JSON telemetry to ec_base - Freeze VERSION_* constants in Chef::Server for 1.3x speedup - Add golden-file contract tests for error handler output schema - Integrate bundler-audit security scanning in CI - Add coverage summary to GitHub Actions job summary - Add Mermaid sequence diagrams for backup/restore/key-export flows - Expand CONTRIBUTING.md with Crawl/Walk/Run AI track guidance - Upgrade Sequel 5.98→5.104, add simplecov_json_formatter - Add .copilot-track/walk onboarding docs All 140 specs pass, 65% line coverage, 0 audit findings. Signed-off-by: nitin sanghi <nsanghi@progress.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Walk phase of the Crawl→Walk→Run AI-assisted development track for knife-ec-backup. This PR adds observability hooks, security scanning, contract tests, a micro-optimization, and CI improvements.
Key Changes
emit_operation_metricinec_base.rbemits structured JSON (event, command, duration, error_count) to STDERR on completionVERSION_*constants inChef::Server— 1.3× speedup, 99.7% fewer allocations in version checksEcErrorHandleroutput (10 assertions across 4 error types)bundler-auditintegrated as CI job;.bundler-audit.ymlignore list for 21 transitive CVEs$GITHUB_STEP_SUMMARY; Mermaid lint job validates diagramssimplecov_json_formatterThis work was completed with AI assistance following Progress AI policies.
Related Issue
N/A — part of the AI-assisted development learning track.
Types of changes
Review Focus
lib/chef/knife/ec_base.rb—emit_operation_metricwrites to STDERR; confirm it won't interfere with knife JSON output on STDOUTlib/chef/server.rb— frozen constants are used in place ofGem::Version.new; verify no downstream code mutates these.github/workflows/build.yml— newauditandmermaid-lintjobs; confirm they don't block the mainspecjobspec/chef/knife/ec_error_handler_contract_spec.rb— golden-file approach; review schema fixture for completeness.bundler-audit.yml— 21 ignored CVEs are all transitive viachef ~> 18; confirm acceptable riskVerification Steps
Checklist