Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions cheroot/test/test_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -400,15 +400,6 @@ def test_reuse_port(http_server, ip_addr, mocker):
assert spy.spy_exception is None


ISSUE511 = IS_MACOS


if not IS_WINDOWS and not ISSUE511:
test_high_number_of_file_descriptors = pytest.mark.forked(
test_high_number_of_file_descriptors,
)


@pytest.fixture
def _garbage_bin():
"""Disable garbage collection when this fixture is in use."""
Expand Down
1 change: 1 addition & 0 deletions docs/changelog-fragments.d/502.contrib.rst
1 change: 1 addition & 0 deletions docs/changelog-fragments.d/511.contrib.rst
1 change: 1 addition & 0 deletions docs/changelog-fragments.d/680.contrib.rst
1 change: 1 addition & 0 deletions docs/changelog-fragments.d/681.contrib.rst
15 changes: 15 additions & 0 deletions docs/changelog-fragments.d/703.contrib.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
The test infrastructure has been updated to stop using
the ``pytest-forked`` plugin
-- by :user:`jaraco` and :user:`webknjaz`.

This plugin was causing problems with upgrading to modern
versions of Pytest and it is not going to be fixed anytime
soon.

It was used in a test that interacts with the system
resource limits under \*NIX environments in hopes to isolate
the side effects caused by the preparatory code.

It is possible that this will have an effect on the test
sessions and we may have to look for alternative solutions
for test process isolation.
9 changes: 3 additions & 6 deletions requirements/tests.in
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,15 @@ pypytools

pytest-clarity
pytest-cov==2.12.0
pytest-forked>=1.2.0; sys_platform != "win32"
pytest-mock>=1.11.0
pytest-rerunfailures
pytest-sugar>=0.9.3
pytest-watch==4.2.0
pytest-xdist>=1.28.0

# pytest-forked is currently incompatible with pytest 7
# Refs:
# * https://github.com/cherrypy/cheroot/issues/511
# * https://github.com/pytest-dev/pytest-forked/issues/67
pytest >= 4.6.6, < 7
# pytest 7.2 introduces deprecations triggered by pytest-cov
# * https://github.com/cherrypy/cheroot/issues/682
pytest >= 7, <7.2

# HTTP over UNIX socket
requests-unixsocket
Expand Down