#73 Update to use astral-sh as the base for Python#75
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Pythia build system to leverage python-build-standalone, significantly simplifying the codebase by removing the need to build Python and its dependencies from source. The update introduces astral-to-pythia.sh for environment generation and updates the configuration and testing scripts accordingly, while deleting numerous legacy build functions and patches. Feedback identifies critical issues with undefined variables in the new build script, a potential failure in the distribution upload process due to existing directories, and several typographical errors in the documentation and configuration files.
adiroiban
force-pushed
the
73-astra-sh-base
branch
from
11068ab to
ccdd49b
Compare
adiroiban
force-pushed
the
73-astra-sh-base
branch
from
460bded to
fcb6795
Compare
Member
Author
|
Test pass in chevah/server ... merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fixes #73
Changes
Download and repack
Add zipfile patch
On WIndows install pywin32 as the only package left.
Move all GHA into a single workflow file.
Remove a lot of the old code that was designed to compile python on Linux and macOS
Testing
Tests will be done via chevah/server
I have executed the manual compat test locally...but for CI this needs an update to compat first.