Remove 'details' link. Change 'Learn more' link to 'Learn more details'#607
Remove 'details' link. Change 'Learn more' link to 'Learn more details'#607sophm256 merged 5 commits intochicagopython:mainfrom
Conversation
…more details' only when topic is truncated
Made one more change. I changed it so that the "Learn more details" link only shows up under the topics that have been truncated. I intentially set wordcount > 90 and truncatewords_html to 80 instead of them being the same. This is because I don't think wordcount treats html the same way as truncatewords_html treats html. |
|
I'd rather we stick with the phrasing "learn more" or "details" vs. "learn more details", but otherwise, this looks great! Since @JoeJasinski was the last one to work on this page, I tagged him as a reviewer. If he doesn't have any concerns, I'm inclined to approve w/ that change. |
| <a href="{% url 'meeting' next_meeting.pk %}">Learn more</a> | ||
| {% if topic.description|nh3|wordcount > 90 %} | ||
| {{ topic.description|nh3|truncatewords_html:80|safe }} | ||
| <a href="{% url 'meeting' next_meeting.pk %}">Learn more details</a> |
There was a problem hiding this comment.
Let's keep the link text as either "learn more" or "details".
|
Thanks for reviewing. Agreed, I prefer a shorter phrasing as well. I've changed it to "Learn more". The change has been made and pushed. |
2 participants
What the results of the PR looks like.
Fixes issue #576