-
Notifications
You must be signed in to change notification settings - Fork 120
Update pyparsing requires lock to be more strict #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2 similar comments
|
Thank you @KevinMFong for your PR! |
|
No problem, thanks for maintaining this package! |
|
breaks compatibility while installing with Python2.7 and pip==20.1.1 Can you use Error: |
|
Related Open PR: https://github.com/chimpler/pyhocon/pull/276/commits |
|
As the failing CI in #276 shows, there is an additional problem with pyparsing 3.0 (in addition to the SyntaxError on 3.5). |
|
As another addition to this: Since the release of Exception It seems to be related to the time period keywords. So apparently the issue occurs because the line break between the assignments is interpreted as a white space, resulting in it being read as The issue seems to be known on pyparsing side: pyparsing/pyparsing#359 |
Summary
Update
pyparsinginstall_requireslock insetup.pyto be more strict and prevent installingpyparsing>=3when installingpyhocon.The recent
pyparsingv3 release dropped support for Python 3.5. Without this change, runningpyhoconon Python 3.5 can result inSyntaxErrorerrors.