Updated styling of the tooltip inner TouchableHighlight to fill the size of the tooltip container#11
Updated styling of the tooltip inner TouchableHighlight to fill the size of the tooltip container#11msftsvachon wants to merge 2 commits intochirag04:masterfrom
Conversation
…he size of the tooltip container
ToolTip.ios.js
Outdated
| render: function() { | ||
| return ( | ||
| <RCTToolTipText ref='toolTipText' onChange={this.handleToolTipTextChange}> | ||
| <RCTToolTipText ref='toolTipText' onChange={this.handleToolTipTextChange} style={this.props.style}>> |
There was a problem hiding this comment.
there is syntax error here
There was a problem hiding this comment.
Sorry, copy/paste error. Fixed.
|
Hello, thanks for the PR, I'm not sure if that's needed what is the behavior you are seeing right now? Can you make a gif for the 2 differences ? Thanks |
|
An example of the issue with the current version is this: Create a list view that grows vertically with the proper flex styling to wrap the content to the next line when the text is longer than the width of the screen. Without the proper flex styling it won't wrap and you'll have text truncation at the end of the first line instead of having it flow to the next line. I've been using this fixed version locally for a while now and thought I'd contribute it back for others. |
|
@jrichardlai, @chirag04, are you guys ok with approving the PR? |
|
It seems that its completely overriding the style so if someone were intending to have some style for the |
2 participants
Otherwise, any content that is wrapped by a tooltip wouldn't flow properly in a flex layout.