Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 8, 2026

The build/configs directory was being polluted with module binaries (.dmf, .dmd, .dmp) when it should contain only configuration files for the dmffs filesystem. The root cause was using the wrong dmf-get parameter.

Changes

  • modules/CMakeLists.txt: Changed dmf-get parameter from -o (output directory) to --config-dir when extracting configuration files from DMD

Root Cause

The original code used -o (output directory) which is a general parameter that may create intermediate module files during processing. The --config-dir parameter is specifically designed for configuration file installation and ensures only configuration files are placed in the target directory.

Result

Config directory now contains only the clean hierarchy:

build/configs/
└── dmclk/
    └── stm32f746g-disco.ini

Module binaries remain properly isolated in build/dmf/.

This matches the expected behavior shown in the issue example using dmf-get dmclk --config board/stm32f746g-disco.ini --config-dir /tmp/config.

Original prompt

This section details on the original issue you should resolve

<issue_title>Niepoprawne używanie konfiguracji dmf-get config</issue_title>
<issue_description>Z jakiegoś dziwnego powodu katalog build/configs zawiera pełno plików dmf, dmd itd... A tymczasem powinien tylko zawierać pliki konfiguracyjne, przykład:

pkubiak@pkubiak-PB50-70RF-RD-RC:~/Projects/choco-technologies/public/dmod-boot$ tree /tmp/config
/tmp/config
└── dmclk
    └── stm32f746g-disco.ini

1 directory, 1 file

Dla:

dmf-get dmclk --config board/stm32f746g-disco.ini --config-dir /tmp/config --cpu-family stm32f7 --skip-arch-check

Trzeba ustalić dlaczego cmake robi taki burdel w tym katalogu
</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits February 8, 2026 13:19
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix incorrect usage of dmf-get config Clean module binaries from config directory after dmf-get extraction Feb 8, 2026
Copilot AI requested a review from JohnAmadis February 8, 2026 13:22
COMMAND ${DMF_GET} -d "${DMBOOT_MODULES_DMD}" -o "${DMBOOT_CONFIGS_TEMP_DIR}" -t "${DMOD_TOOLS_NAME}" --cpu-family "${DMBOOT_MCU_SERIES}" -y --type dmfc
COMMAND ${CMAKE_COMMAND} -E echo "Copying configuration files to ${DMBOOT_CONFIG_DIR}..."
COMMAND ${CMAKE_COMMAND} -E copy_directory "${DMBOOT_CONFIGS_TEMP_DIR}" "${DMBOOT_CONFIG_DIR}"
COMMAND ${CMAKE_COMMAND} -E echo "Removing module files (.dmf, .dmd, .dmp) from config directory..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot jakie removing?! dmf-get sam instaluje poprawnie pliki konfiguracyjne, ktore sa podane do sciezki ktora podasz jako --config-dir - nic wiecej nie potrzeba. Nie wiem co ty tu odwalasz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right! The issue was using -o instead of --config-dir. Changed to use --config-dir parameter which properly installs only config files without intermediates. Fixed in a2ec801.

Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot AI changed the title Clean module binaries from config directory after dmf-get extraction Use --config-dir parameter for dmf-get configuration extraction Feb 8, 2026
Copilot AI requested a review from JohnAmadis February 8, 2026 13:27
@JohnAmadis JohnAmadis closed this Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Niepoprawne używanie konfiguracji dmf-get config

2 participants