Skip to content

feat: make filename-based status management optional#16

Merged
choplin merged 1 commit into
mainfrom
feat/optional-status-management
Jul 12, 2025
Merged

feat: make filename-based status management optional#16
choplin merged 1 commit into
mainfrom
feat/optional-status-management

Conversation

@choplin

@choplin choplin commented Jul 12, 2025

Copy link
Copy Markdown
Owner

Summary

  • Make the filename-based status management feature optional
  • Add new configuration option comment.status_management (default: false)
  • Show warning messages when status management operations are attempted while disabled

Changes

  • Added comment.status_management configuration option
  • Updated file storage backend to respect the status_management setting
  • Added warning messages for resolve/reopen operations when status management is disabled
  • Updated tests to verify both enabled and disabled behavior
  • Updated documentation

Behavior

  • When status_management = false (default):

    • Files are saved without status prefixes (e.g., 1234567890.md)
    • Resolve/reopen operations show a warning and return false
    • Thread status is not tracked
  • When status_management = true (with file storage backend):

    • Files use status prefixes (e.g., action-required_1234567890.md)
    • Status automatically updates based on comment authors
    • Resolve/reopen operations work as expected

Test plan

  • All existing tests pass
  • New test added for status_management = false behavior
  • Manual testing with both settings

- Add `comment.status_management` configuration option (default: false)
- Status management only works when both storage.backend = "file" and status_management = true
- Show warning messages when trying to resolve/reopen threads with status management disabled
- Update tests to verify both enabled and disabled behavior
- Update documentation with new configuration option
@choplin choplin force-pushed the feat/optional-status-management branch from 1445319 to 62247b0 Compare July 12, 2025 05:33
@choplin choplin merged commit b412e22 into main Jul 12, 2025
3 checks passed
@choplin choplin mentioned this pull request Jul 12, 2025
4 tasks
@choplin choplin deleted the feat/optional-status-management branch July 12, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant