Fix stale browser views after restarting in another directory#70
Merged
Conversation
Directory listings were being served through Go's FileServer, which meant the browser could revalidate / with If-Modified-Since and get a 304 Not Modified. When go-grip was restarted on the same host and port in a different folder, the browser could then reuse the previous run's HTML and show an old file list. Refactor the server to use a local mux, mark directory listings and rendered markdown pages as non-cacheable, strip conditional cache validators before directory requests reach FileServer, and add regression tests for the directory, markdown, and regular file cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directory listings were being served through Go's FileServer, which meant the browser could revalidate / with
If-Modified-Since and get a
304 Not Modified. When go-grip was restarted on the same host and port in a different folder, the browser could then reuse the previous run's HTML and show an old file list.Refactor the server to use a local mux, mark directory listings and rendered markdown pages as non-cacheable, strip conditional cache validators before directory requests reach FileServer, and add regression tests for the directory, markdown, and regular file cases.