Add config files to experiment on the performance between dense and MOE blocks in attention layers#18
Open
Adefioye wants to merge 4 commits intochrisjmccormick:mainfrom
Open
Add config files to experiment on the performance between dense and MOE blocks in attention layers#18Adefioye wants to merge 4 commits intochrisjmccormick:mainfrom
Adefioye wants to merge 4 commits intochrisjmccormick:mainfrom
Conversation
Owner
|
@Adefioye: Hey Koko! For the config files, can you update the filenames and the "shorthand" and "notes" fields to reflect the experiment? For the shorthand (see the example below), there's a term "mlp.1024"--that refers to dense FFNs with an intermediate size of 1024. For yours, you could change this to something like You can make a similar tweak to the filenames, and the output directories as well. |
Owner
|
@Adefioye - Since we moved this DeepSeekV3-based implementation into its own directory, maybe what makes the most sense here is to add your experiment results to the deepseek/README.md? We could add your config files there as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental Results for MOE vs Dense
MLA Variants
MLA-O Variants
Insights:
My thoughts: