Widen swift-syntax constraint to support Swift 6.1+ (601.x)#34
Widen swift-syntax constraint to support Swift 6.1+ (601.x)#34iliasaz wants to merge 1 commit intochristopherkarani:mainfrom
Conversation
The previous `from: "600.0.0"` constraint restricted resolution to 600.x.x only (Swift 6.0). Xcode 26.3+ ships Swift 6.2 which requires swift-syntax 601.0.1+ for compatible prebuilt modules. Widening to "600.0.0"..<"700.0.0" allows the resolver to pick any 600–699 release. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d63c39dfec
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // MARK: Cross-Platform Dependencies | ||
| .package(url: "https://github.com/apple/swift-collections.git", from: "1.1.0"), | ||
| .package(url: "https://github.com/swiftlang/swift-syntax.git", from: "600.0.0"), | ||
| .package(url: "https://github.com/swiftlang/swift-syntax.git", "600.0.0"..<"700.0.0"), |
There was a problem hiding this comment.
Regenerate lockfile to actually pick swift-syntax 601+
This manifest change alone does not move this repository off swift-syntax 600.x because Package.resolved is still pinned to 600.0.1 (Package.resolved lines 283-289). In any environment that honors the lockfile (including local/CI builds of this repo), resolution will continue using 600.0.1, so toolchains that need 601.x compatibility will still fail despite the widened range; the lockfile needs to be updated in the same change.
Useful? React with 👍 / 👎.
|
@claude This manifest change alone does not move this repository off swift-syntax 600.x because Package.resolved is still pinned to 600.0.1 (Package.resolved lines 283-289). In any environment that honors the lockfile (including local/CI builds of this repo), resolution will continue using 600.0.1, so toolchains that need 601.x compatibility will still fail despite the widened range; the lockfile needs to be updated in the same change. Useful? React with 👍 / 👎. |
|
Thanks for the contribution @iliasaz! Closing this because SPM's |
The previous
from: "600.0.0"constraint restricted resolution to 600.x.x only (Swift 6.0). Xcode 26.3+ ships Swift 6.2 which requires swift-syntax 601.0.1+ for compatible prebuilt modules. Widening to "600.0.0"..<"700.0.0" allows the resolver to pick any 600–699 release.