Skip to content

Widen swift-syntax constraint to support Swift 6.1+ (601.x)#34

Closed
iliasaz wants to merge 1 commit intochristopherkarani:mainfrom
iliasaz:main
Closed

Widen swift-syntax constraint to support Swift 6.1+ (601.x)#34
iliasaz wants to merge 1 commit intochristopherkarani:mainfrom
iliasaz:main

Conversation

@iliasaz
Copy link
Copy Markdown

@iliasaz iliasaz commented Mar 1, 2026

The previous from: "600.0.0" constraint restricted resolution to 600.x.x only (Swift 6.0). Xcode 26.3+ ships Swift 6.2 which requires swift-syntax 601.0.1+ for compatible prebuilt modules. Widening to "600.0.0"..<"700.0.0" allows the resolver to pick any 600–699 release.

The previous `from: "600.0.0"` constraint restricted resolution to
600.x.x only (Swift 6.0). Xcode 26.3+ ships Swift 6.2 which requires
swift-syntax 601.0.1+ for compatible prebuilt modules. Widening to
"600.0.0"..<"700.0.0" allows the resolver to pick any 600–699 release.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d63c39dfec

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

// MARK: Cross-Platform Dependencies
.package(url: "https://github.com/apple/swift-collections.git", from: "1.1.0"),
.package(url: "https://github.com/swiftlang/swift-syntax.git", from: "600.0.0"),
.package(url: "https://github.com/swiftlang/swift-syntax.git", "600.0.0"..<"700.0.0"),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate lockfile to actually pick swift-syntax 601+

This manifest change alone does not move this repository off swift-syntax 600.x because Package.resolved is still pinned to 600.0.1 (Package.resolved lines 283-289). In any environment that honors the lockfile (including local/CI builds of this repo), resolution will continue using 600.0.1, so toolchains that need 601.x compatibility will still fail despite the widened range; the lockfile needs to be updated in the same change.

Useful? React with 👍 / 👎.

@christopherkarani
Copy link
Copy Markdown
Owner

@claude This manifest change alone does not move this repository off swift-syntax 600.x because Package.resolved is still pinned to 600.0.1 (Package.resolved lines 283-289). In any environment that honors the lockfile (including local/CI builds of this repo), resolution will continue using 600.0.1, so toolchains that need 601.x compatibility will still fail despite the widened range; the lockfile needs to be updated in the same change.

Useful? React with 👍 / 👎.

@christopherkarani
Copy link
Copy Markdown
Owner

Thanks for the contribution @iliasaz! Closing this because SPM's from: "600.0.0" already allows resolving to 601.x+ — it's a minimum version, not an exact match. So Swift 6.2 / swift-syntax 601.x is already supported by the current constraint. Appreciate you looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants