Fix CI-breaking registry and diffusion test regressions#39
Open
christopherkarani wants to merge 1 commit intomainfrom
Open
Fix CI-breaking registry and diffusion test regressions#39christopherkarani wants to merge 1 commit intomainfrom
christopherkarani wants to merge 1 commit intomainfrom
Conversation
…ests - align DiffusionModelDownloaderTests compile gate with production symbol gate (CONDUIT_TRAIT_MLX + MLX + Hub/HuggingFace) - update ModelIdentifierTests expectations for current registry composition including Kimi cloud models - replace brittle capability/provider assumptions with invariant assertions that still validate registry semantics - update ProviderType case-iterable test to current 12-case API surface (adds kimi/minimax) - verify with focused regression tests, full swift build, and full swift test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This mission-critical audit run found and fixed deterministic CI blockers introduced by API/catalog evolution.
Issues fixed
Compile-gate mismatch in diffusion tests (hard CI failure on non-MLX environments)
Tests/ConduitTests/ImageGeneration/DiffusionModelDownloaderTests.swiftcompiled with#if canImport(Hub)only.DiffusionModelDownloaderis gated byCONDUIT_TRAIT_MLX && canImport(MLX) && (canImport(Hub) || canImport(HuggingFace)).Stale model catalog assertions after provider/model expansion (CI failures)
Tests/ConduitTests/Core/ModelIdentifierTests.swiftassumed old registry totals/provider distributions.kimi) and changed capability distribution.Outdated
ProviderTypecase-count expectation (CI failure)Tests/ConduitTests/Core/ProtocolCompilationTests.swiftexpected 10 provider cases.kimi,minimaxadded).Why this matters
Verification
swift test --filter DiffusionModelDownloaderTestsswift test --filter ModelIdentifierTests --filter ProtocolCompilationTestsswift buildswift testAll commands pass in this workspace.
Scope