Added option on job to specify waitRetryDelay and bumped API version …#7
Added option on job to specify waitRetryDelay and bumped API version …#7tbfangel wants to merge 2 commits intochrylis:masterfrom
Conversation
|
This looks potentially useful. Are there any changes to the postback format in 1.22 that could potentially cause trouble? The chained constructor looks fine, but please remove the whitespace commit noise; in particular, the blank lines around the assignments are there intentionally to group the constraint checks with their values. Note that as of Java 8, all of the Javadocs need to be filled out (e.g., no blank |
|
OK, I'll commit the changes as you suggest one of the next days. Concerning the API version, I have not noticed anything that could potentially cause trouble. We have been running with API level 1.22 for some time now and haven't had any issues so far (but we're also only using a very small subset of the functionality). BTW, I actually have a somewhat bigger change that adds long polling to the library. Since our service is in a private network, we cannot rely on post backs, so I have added a long poll request. Would you be interested in me adding this in a different PR? |
|
Any progress on merging this PR? |
…to 1.22