Added fix for #30 to fix problem with items of different height shown correctly in list#87
Open
mortenholmgaard wants to merge 1 commit intochthai64:masterfrom
Open
Conversation
…ght shown correctly in list
|
my library as response for this issue https://github.com/sulo61/SimpleSwipeMenuLayout-SSML |
mnaturel
reviewed
May 15, 2019
| // create new measure spec using the largest child width | ||
| widthMeasureSpec = MeasureSpec.makeMeasureSpec(desiredWidth, widthMode); | ||
| heightMeasureSpec = MeasureSpec.makeMeasureSpec(desiredHeight, heightMode); | ||
| heightMeasureSpec = MeasureSpec.makeMeasureSpec(desiredHeight, MeasureSpec.EXACTLY); |
There was a problem hiding this comment.
@mortenholmgaard In our case, we had to keep the current heightMode to have the correct behavior. If we use MeasureSpec.EXACTLY it stretches too much the view : we loose some margins.
And thanks for the fix by the way !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix problem with items of different height shown correctly in list
with code from @OJIer3 in this issue: #30