Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix exception
IllegalArgumentException: Task size too large.These exceptions appears at cron jobs when the payload is too large, and it occurs a lot since one of the arguments is a html email body.
The maximum task size is 100KB for push queues https://cloud.google.com/appengine/quotas#Task_Queue
We already had the EmailNotification Kind, and it is used to track when a email was sent (with success/failure status).
Changes in it:
rulewas removed since it isn't used and the value is null for all existing entitiessubjectandbodywas added to receive the email informationtimestampwas added to track when the entity was createdOther changes were made in two points:
pushandexecute