fix(docs): suppress Doxygen auto-linking of text in jsonb selector @warning - #385
Merged
Merged
Conversation
…warning Doxygen auto-links the bare word `text` (it collides with a documented symbol) into a cross-reference — even inside inline code. In the jsonb selector operator's @warning, `` `col -> 'sel'::text` `` became `<computeroutput>col -> 'sel'<ref>text</ref></computeroutput>`: a link nested inside inline code. Rendered to Markdown that surfaces as an unbalanced `<tt>`, which fails the downstream MDX/docs build (cipherstash/docs was broken by eql-3.0.0-alpha.3's API.md at line 2153, `Expected a closing tag for <tt>`). It also drops the `::`, so the cast read as `'sel'text`. Prefix the two `text` occurrences with Doxygen's `%` no-autolink marker (`::%text`, `-> %text`). Verified with doxygen: the nested <ref> is gone and `col -> 'sel'::text` now renders as clean, balanced inline code.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #384
Problem
Doxygen auto-links the bare word
text(it collides with a documented symbol) into a cross-reference inside inline code in the jsonb selector operator's@warning:A
<ref>nested in<computeroutput>renders to an unbalanced<tt>inAPI.md, which broke the cipherstash/docs MDX build on eql-3.0.0-alpha.3 (index.mdx:2153: Expected a closing tag for <tt>). The::was dropped too, so the cast read'sel'text.Fix
Prefix the two
textoccurrences with Doxygen's%no-autolink marker (::%text,-> %text) insrc/v3/jsonb/operators.sql. The%is consumed by Doxygen (not rendered).Verification
Ran
doxygenon the changed source:<ref>is gone.col -> 'sel'::textrenders as clean, balanced inline code (the::is preserved).Note: my local doxygen is 1.15.0, which masks the
<tt>symptom; please confirm against the CI doxygen version. The fix removes the version-independent trigger (the nested<ref>), so it resolves the break on any version.Related
<tt>tags so a stray one can't break the build docs#52 (defensively strips<tt>in the docs generator).AUTOLINK_SUPPORT = NOin the Doxyfile.