docs(skills): trusted publishing is live, not deferred — plus a first-publish runbook - #849
Conversation
…-publish runbook The stash-supply-chain-security skill still listed provenance attestations and OIDC trusted publishing under "What's Deferred (Follow-Up PR)" and told readers release.yml needs NPM_TOKEN dropped. Both landed a while ago: release.yml publishes with no token at all, and rc.4 tarballs carry SLSA provenance. Replace that section with what is actually true, including the constraints that keep it working and are easy to undo by accident: id-token: write, a GitHub-hosted runner (npm rejects provenance from self-hosted with E422), never setting NPM_TOKEN (changesets/action writes a token .npmrc that shadows OIDC and fails with E404 — npm/cli#8976), npm >= 11.5.1, and no Actions cache in a credential-bearing job. Add a runbook for publishing a package name that has never been published. A trusted publisher is configured per package on npmjs.com, so it can only be attached to a package that already exists — a brand-new name cannot be released by release.yml on its own and needs a manual placeholder publish first. This is why stack-drizzle and stack-supabase carry 0.0.0 placeholders (those versions have no attestations; their rc builds do). @cipherstash/stack-prisma is 404 on the registry today and hits this at GA — see #661. Skills ship inside the stash tarball, so this carries a stash patch changeset.
🦋 Changeset detectedLatest commit: b7e9fdf The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reached
Next review available in: 17 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Documentation correction. |
What
skills/stash-supply-chain-security/SKILL.mdstill described npm provenance attestations and OIDC trusted publishing as deferred follow-up work, and told readersrelease.ymlneedsNPM_TOKENdropped. Both landed a while ago —release.ymlpublishes with no token at all, and published tarballs carry SLSA provenance:Since skills ship inside the
stashtarball and are copied into customer repos byinstallSkills(), a stale section here is wrong guidance in someone else's codebase, not just an internal note.Changes
permissions: id-token: write— mints the OIDC tokenruns-on: ubuntu-latest, never self-hosted — npm rejects provenance from non-GitHub-hosted runners with E422NPM_TOKEN—changesets/actionwrites a token.npmrcthat shadows OIDC and fails every publish with E404 (OIDC trusted publishing E404 when publishing scoped packages from changesets/action npm/cli#8976)scripts/lint-no-workflow-caching.mjs)release.ymlon its own and needs a manual placeholder publish first. Coverspnpm publish(notnpm publish, because ofworkspace:*deps), thebootstraptag, deprecating the placeholder, cleaning the tag up afterwards, and thepublishConfig.accessrequirement.npm deprecate,npm dist-tag).descriptionand "When to Use This Skill" updated so the skill triggers onrelease.ymland first-publish work.Why now
@cipherstash/stack-prisma(renamed from@cipherstash/prisma-nextin #844) has never been published:So the GA release run can't publish it — no package, no trusted-publisher config, nothing for the OIDC token to match — and the result would be a partial release: the rest of the fixed group at 1.0.0 with the Prisma adapter missing. That's the same reason
stack-drizzleandstack-supabasecarry0.0.0placeholders; those versions have no attestations, their rc builds do, which confirms the placeholders were name-claiming rather than cosmetic.Written up as a GA blocker on #661 (comment: #661 (comment)). This PR is the durable half — so the next new package doesn't rediscover it at release time.
Testing
Docs-only.
pnpm run code:checkreports no errors (pre-existing warnings only, which is what CI gates on).Changeset
stashpatch —skills/ships in thestashtarball, so a skills-only change is user-facing.