Conversation
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
Signed-off-by: lc3267 <melvin.strobl@kit.edu>
refactoring conflicting 'm' module
stroblme
reviewed
Nov 9, 2023
Member
stroblme
left a comment
stroblme
left a comment
There was a problem hiding this comment.
Thanks for the great work!
Added some review comments, mostly regarding config files.
Still need to 'test the test', but looks good so far! :)
Member
There was a problem hiding this comment.
Das können wir vermutlich löschen oder?
Member
There was a problem hiding this comment.
Das sieht für mich eher nach einer Test-Konfiguration aus. Das sollte eher lokal bleiben und nicht Teil des Commits werden.
Member
There was a problem hiding this comment.
Auch das hier, gerne einfach löschen, da es nur eine lokale Konfiguration ist.
Member
There was a problem hiding this comment.
Bin mir nicht ganz sicher, aber brauchen wir den Teil nicht?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of Tests solving #24.
You can start the tests by running pytest.
This takes a lot of time because of the test test_optimizer.
command to test data_processing:
pytest -v src/tests/pipelines/data_processing/test_pipeline.py::TestDataPreparation
command to test training:
pytest -v src/tests/pipelines/data_science/test_pipeline.py::TestTraining
command to test all optimizers:
pytest -v src/tests/pipelines/data_science/test_pipeline.py::test_optimizer