Add SemanticUI.Modules.Dropdown.Selection.menuItem#25
Open
Add SemanticUI.Modules.Dropdown.Selection.menuItem#25
Conversation
This renders a selection dropdown with the `item` class, suitable for use in `ui menu` components.
| [ ( "compact", compact ), ( "selection", True ) ] | ||
|
|
||
| MenuItem -> | ||
| [ ( "inline", True ), ( "item", True ) ] |
Contributor
There was a problem hiding this comment.
I don't see inline in the semantic ui examples for this - possible it's specific to the menu you're building?
Contributor
|
I'm ok with this PR as is, though I think it's possible you may want to have it as module Menu.Item
type Config = { active : Bool, inline : Bool }
module Dropdown
type Variation msg
= Ordinary
| Item (Menu.Item.Config msg) -- Config from Menu.Item...
| Button (Button.Config msg) -- ...similar to thisbecause the order in which classes are applied appears to matter, so technically it would need to be (though often, but not always, a random order works by accident) See: for how it works with button at the moment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renders a selection dropdown with the
itemclass, suitable foruse in
ui menucomponents.