Skip to content

Fix GCC 15+ build warnings on Ubuntu 26.04 #8604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix GCC 15+ build warnings on Ubuntu 26.04 #8604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
108c2a6
Initial plan
Copilot Jun 1, 2026
6e61790
Fix GCC 15 build warnings on the affected source files
Copilot Jun 1, 2026
a5ec1e3
Merge branch 'main' into copilot/resolve-build-warnings-citus
ihalatci Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/backend/distributed/cdc/cdc_decoder_utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ CdcExtractShardIdFromTableName(const char *tableName, bool missingOk)
char *shardIdStringEnd = NULL;

/* find the last underscore and increment for shardId string */
char *shardIdString = strrchr(tableName, SHARD_NAME_SEPARATOR);
const char *shardIdString = strrchr(tableName, SHARD_NAME_SEPARATOR);
if (shardIdString == NULL && !missingOk)
{
ereport(ERROR, (errmsg("could not extract shardId from table name \"%s\"",
Expand Down
2 changes: 1 addition & 1 deletion src/backend/distributed/commands/multi_copy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@


/* constant used in binary protocol */
static const char BinarySignature[11] = "PGCOPY\n\377\r\n\0";
static const char BinarySignature[11] pg_attribute_nonstring = "PGCOPY\n\377\r\n\0";

/* if true, skip validation of JSONB columns during COPY */
bool SkipJsonbValidationInCopy = true;
Expand Down
2 changes: 1 addition & 1 deletion src/backend/distributed/utils/citus_safe_lib.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ SafeBsearch(const void *key, const void *ptr, rsize_t count, rsize_t size,
* does. We cannot use bsearch_s as a replacement, since it's not available
* in safestringlib.
*/
return bsearch(key, ptr, count, size, comp); /* IGNORE-BANNED */
return (void *) bsearch(key, ptr, count, size, comp); /* IGNORE-BANNED */
}


Expand Down
2 changes: 1 addition & 1 deletion src/backend/distributed/worker/worker_data_fetch_protocol.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ ExtractShardIdFromTableName(const char *tableName, bool missingOk)
char *shardIdStringEnd = NULL;

/* find the last underscore and increment for shardId string */
char *shardIdString = strrchr(tableName, SHARD_NAME_SEPARATOR);
const char *shardIdString = strrchr(tableName, SHARD_NAME_SEPARATOR);
if (shardIdString == NULL && !missingOk)
{
ereport(ERROR, (errmsg("could not extract shardId from table name \"%s\"",
Expand Down
13 changes: 13 additions & 0 deletions src/include/pg_version_compat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,4 +477,17 @@ getStxstattarget_compat(HeapTuple tup)
" MINVALUE " INT64_FORMAT " MAXVALUE " INT64_FORMAT \
" START WITH " INT64_FORMAT " CACHE " INT64_FORMAT " %sCYCLE"

/*
* pg_attribute_nonstring marks a character array that is not meant to be
* NUL-terminated, silencing -Wunterminated-string-initialization (GCC 15+).
* It was introduced in PostgreSQL 18, so provide a fallback for older versions.
*/
#ifndef pg_attribute_nonstring
#if defined(__has_attribute) && __has_attribute(nonstring)
#define pg_attribute_nonstring __attribute__((nonstring))
#else
#define pg_attribute_nonstring
#endif
#endif

#endif /* PG_VERSION_COMPAT_H */
Loading