columnar: re-implement parallel/index-only-scan suppression on PG19#8619
Open
ihalatci wants to merge 1 commit into
Open
columnar: re-implement parallel/index-only-scan suppression on PG19#8619ihalatci wants to merge 1 commit into
ihalatci wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pg19-columnar-index #8619 +/- ##
====================================================
Coverage 88.95% 88.96%
====================================================
Files 288 288
Lines 64376 64386 +10
Branches 8093 8094 +1
====================================================
+ Hits 57267 57278 +11
- Misses 4776 4777 +1
+ Partials 2333 2331 -2 🚀 New features to boost your workflow:
|
ihalatci
force-pushed
the
pg19-columnar-relinfo
branch
from
d0bf1ee to
004a41d
Compare
ihalatci
force-pushed
the
pg19-columnar-index
branch
from
a31f940 to
83042a9
Compare
PG19 removed get_relation_info_hook, which is where pre-PG19 builds disable
parallel query and index-only scans for columnar relations (columnar scans are
always serial and cannot return tuples from an index). Re-implement that
suppression for PG19 inside ColumnarSetRelPathlistHook:
* forbid future parallel workers (rel_parallel_workers = 0,
consider_parallel = false) and drop any already-generated partial paths;
* clear each index's canreturn flags and strip any IndexOnlyScan paths that
were already created.
The pre-PG19 ColumnarGetRelationInfoHook path is unchanged. Removes the
Phase-1 TODO(PG19, #8614) placeholder in columnar_customscan_init.
DESCRIPTION: Suppress parallel and index-only scans for columnar tables on PG19
Closes #8614
Part of #8597
ihalatci
force-pushed
the
pg19-columnar-relinfo
branch
from
004a41d to
f25e811
Compare
ihalatci
force-pushed
the
pg19-columnar-index
branch
from
83042a9 to
59c5dc3
Compare
This was referenced Jun 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Re-implements PG19-specific planner suppression for columnar relations now that upstream removed get_relation_info_hook, ensuring the planner won’t choose unsupported parallel or index-only scan paths for columnar tables.
Changes:
- Adds PG19-only logic in
ColumnarSetRelPathlistHookto disable parallel planning (setrel_parallel_workers = 0,consider_parallel = false, and clearpartial_pathlist). - Clears per-index
canreturnflags and removes already-generatedIndexOnlyScanpaths for columnar relations on PG19. - Replaces the removed PG19 TODO with a comment explaining where the suppression now lives.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR (PR3b of the PG19 stack). Base =
pg19-columnar-index(#8618) →pg19-runtime-fixes(#8617) →pg19-ci-test-matrices(#8616) →pg19-ruleutils-port(#8602) →pg19-support. Review/merge in stack order.PG19 removed
get_relation_info_hook, which is where pre-PG19 builds disable parallel query and index-only scans for columnar relations (columnar scans are always serial and cannot return tuples from an index). The Phase-1 build left aTODO(PG19, #8614)placeholder; this PR re-implements that suppression insideColumnarSetRelPathlistHook:rel_parallel_workers = 0,consider_parallel = false) and drop any already-generated partial paths;canreturnflags and strip anyIndexOnlyScanpaths that were already created (set_rel_pathlist_hookruns after path generation).The pre-PG19
ColumnarGetRelationInfoHookpath is unchanged.Closes #8614
Part of #8597