Convert interface to type for handler Response types; add missing Response types#160
Draft
Convert interface to type for handler Response types; add missing Response types#160
interface to type for handler Response types; add missing Response types#160Conversation
Member
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Feb 26, 2026 8:16p.m. | Review ↗ |
Co-authored-by: dangowans <19495149+dangowans@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Response types for all post handlers
Convert Feb 26, 2026
interface to type for handler Response types; add missing Response types
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



All post handler
Responsetypes should be exported astype(notinterface) for client-side TypeScript compatibility, following the pattern indoSearchWorkOrders.Changes
shifts-post/doGetNoteTypes—interface DoGetNoteTypesResponse→export type DoGetNoteTypesResponseworkOrders-post/doGetNoteTypes— same conversionworkOrders-post/doGetWorkOrderAccomplishmentData— added missingexport type DoGetWorkOrderAccomplishmentDataResponseunion type and applied it to theResponse<>parameter.d.tsfiles for all threePattern applied
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.