This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Open
Conversation
Member
|
HI! Thanks for the PR. Both use cases make sense – being able to append more data to the request and process the response. The implementation looks good as well. So, conceptually, I think this would be a great addition. To merge this PR we'd need:
Let us know if you want to give those a try and if you have any problems with them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to add a bit of flexibility to the simple upload adapter in order to be able to upload directly to our CDN provider (upload care CDN).
Two things were needed:
{ default: <imageURL> }I don't know if this falls in the scope of this add-on but I find it convenient to use this way. Feel free to close this PR and suggest to split those changes in two PRs if need be.