Replaced DocumentTypes type hint with DocumentTypesBase#353
Open
Replaced DocumentTypes type hint with DocumentTypesBase#353
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes type hint issues in the mmif.Mmif class methods that were causing both pytype errors and runtime crashes when using DocumentTypes in type annotations.
Changes:
- Updated type hints to use
DocumentTypesBaseinstead ofDocumentTypesorAny - Added
DocumentTypesBaseto imports inmmif/serialize/mmif.py
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #353 +/- ##
========================================
Coverage 65.56% 65.56%
========================================
Files 22 22
Lines 2843 2843
========================================
Hits 1864 1864
Misses 979 979
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
acf9a29 to
73da13e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #351