Skip to content

fix(debug): CI fixes for #448#513

Closed
advancedresearcharray wants to merge 1 commit into
clawwork-ai:fix/debug-logger-pre-init-bufferfrom
advancedresearcharray:fix/debug-logger-pre-init-buffer
Closed

fix(debug): CI fixes for #448#513
advancedresearcharray wants to merge 1 commit into
clawwork-ai:fix/debug-logger-pre-init-bufferfrom
advancedresearcharray:fix/debug-logger-pre-init-buffer

Conversation

@advancedresearcharray

Copy link
Copy Markdown
Contributor

Summary

CI fixes for #448:

  • Import LogEventInput from ./logger.js instead of @clawwork/shared (fixes tsc failure)
  • Run Prettier on debug-logger.test.ts (fixes format:check failure)

Test plan

  • pnpm --filter @clawwork/desktop exec tsc --noEmit passes
  • pnpm format:check passes on changed files
  • pnpm --filter @clawwork/desktop test — debug-logger tests pass (4/4)

Made with Cursor

LogEventInput is defined in logger.ts, not @clawwork/shared; importing it
from shared caused tsc failure. Also run Prettier on debug-logger.test.ts.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses CI failures related to build and linting processes. By correcting import paths and standardizing code formatting, the changes ensure that the project's continuous integration pipeline remains stable and passes all required checks.

Highlights

  • Dependency Resolution: Updated the import source for LogEventInput to resolve a TypeScript compilation failure.
  • Code Formatting: Applied Prettier formatting to the debug-logger test suite to ensure compliance with project linting standards.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Hi @advancedresearcharray,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors imports in the desktop package, moving the import of LogEventInput from @clawwork/shared to the local logger module in packages/desktop/src/main/debug/index.ts. Additionally, it simplifies the formatting of dynamic imports in packages/desktop/test/debug/debug-logger.test.ts by consolidating them onto single lines. There are no review comments to address, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@advancedresearcharray

Copy link
Copy Markdown
Contributor Author

Closing as superseded: #412 was fixed on main by #481 (2026-04-30). This CI-fix stack for #448 is no longer needed — the merged implementation uses packages/desktop/test/debug-pre-init-buffer.test.ts and a simpler buffer-and-replay approach in debug/index.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant