fix(debug): CI fixes for #448#513
Conversation
LogEventInput is defined in logger.ts, not @clawwork/shared; importing it from shared caused tsc failure. Also run Prettier on debug-logger.test.ts. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses CI failures related to build and linting processes. By correcting import paths and standardizing code formatting, the changes ensure that the project's continuous integration pipeline remains stable and passes all required checks. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Hi @advancedresearcharray, DetailsInstructions for interacting with me using comments are available here. |
There was a problem hiding this comment.
Code Review
This pull request refactors imports in the desktop package, moving the import of LogEventInput from @clawwork/shared to the local logger module in packages/desktop/src/main/debug/index.ts. Additionally, it simplifies the formatting of dynamic imports in packages/desktop/test/debug/debug-logger.test.ts by consolidating them onto single lines. There are no review comments to address, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
CI fixes for #448:
LogEventInputfrom./logger.jsinstead of@clawwork/shared(fixestscfailure)debug-logger.test.ts(fixesformat:checkfailure)Test plan
pnpm --filter @clawwork/desktop exec tsc --noEmitpassespnpm format:checkpasses on changed filespnpm --filter @clawwork/desktop test— debug-logger tests pass (4/4)Made with Cursor