Enable to specify to closing err cache miss #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing ERR_CACHE_MISS is off by default, this is a hidden parameter for now, so remove descriptions about ERR_CACHE_MISS page from documents.
piroor
reviewed
Sep 9, 2025
piroor
reviewed
Sep 9, 2025
Member
piroor
left a comment
piroor
left a comment
There was a problem hiding this comment.
初期状態での動作のテスト内容が変わるのは妥当だと思いますが、設定を変更したときのテストが不在なのが気になります。
「そこはテストもあってはいけない」ということなら仕方ないのですが、いかがでしょうか。
HashidaTKS
commented
Sep 9, 2025
| internal class Config | ||
| { | ||
| public bool IgnoreQueryString = false; | ||
| public bool OnlyMainFrame = false; |
Contributor
Author
There was a problem hiding this comment.
何故か不要なパラメータが残っていたので削除した。
また、RepostConfirmationCanceler.exeでは、CloseErrCacheMissPageパラメータを使うことがないので、パース処理自体入れていない。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERR_CACHE_MISSページを閉じる処理をグローバル設定の@CLOSE_ERR_CACHE_MISS_PAGEで指定可能とした。また、デフォルト値をなし（無効）とし、
ERR_CACHE_MISSが初期状態では自動で閉じないように修正した。テスト