Feature: CORE-37263 registry cpp wrapper#46
Open
twallis-cpr wants to merge 14 commits into
Open
Conversation
Coverage Summary
Coverage deltas are computed as: PR source branch minus target branch (base commit). Detailed HTML reports are available in the workflow artifacts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the larger proton re-architecture here (internal CPR/OTTO employee eyes only 👀 )
Part 1 of 3 for proton_core's C++ wrapper.
This PR adds:
SignalAccess: class for accessing the signal registry in a semi-generic waySignal: templated class for abstracting a signal (still requires raw pointer access to the registry)SignalBase: non-templated class for signals to live in containersRegistryLock: locking primitive for the registry lock for usage withstd::lock_guardScopedLock: locking primitive that locks in the constructor, and unlocks in destructor.BundleAccess: accessor for bundle APIPROTON_ENABLE_ALLOCfeature flag:SignalBasetoSignal<T>)std::functionwithBundleAccessfor lambdas andstd::bindfor decode callbacks.