fix(localizations): Update tr-TR waitlist translations - #9410
fix(localizations): Update tr-TR waitlist translations#9410emirmuminoglu wants to merge 1 commit into
Conversation
Waitlist is linking to sign in page but the action text is "Still don't have an account?", and action link is "Join Waitlist"
|
|
@emirmuminoglu is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughUpdated two Turkish localization strings. The email placeholder now uses Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/localizations/src/tr-TR.ts`:
- Line 2222: Update the waitlist prompt’s actionText in the Turkish localization
to match the base resource’s “Already have access?” intent by using “Zaten
erişiminiz var mı?”.
- Line 2221: Update the actionLink value in the Turkish localization entry to
use sentence case, changing “Giriş Yap” to “Giriş yap” while leaving the
surrounding localization unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 6e903be4-b5f9-414e-b471-186a4d8a1612
📒 Files selected for processing (1)
packages/localizations/src/tr-TR.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
clerk/clerk_go(manual)clerk/dashboard(manual)clerk/accounts(manual)clerk/backoffice(manual)clerk/clerk(manual)clerk/clerk-docs(manual) → reviewed against branchpatch-1instead of the default branchclerk/cloudflare-workers(manual)
| start: { | ||
| actionLink: 'Bekleme listesine katıl', | ||
| actionText: 'Hala bir hesabınız yok mu?', | ||
| actionLink: 'Giriş Yap', |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use sentence case for the sign-in action.
The same file uses Giriş yap for equivalent sign-in actions at Lines 1521 and 1594. Change Giriş Yap to Giriş yap.
Proposed fix
- actionLink: 'Giriş Yap',
+ actionLink: 'Giriş yap',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| actionLink: 'Giriş Yap', | |
| actionLink: 'Giriş yap', |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/localizations/src/tr-TR.ts` at line 2221, Update the actionLink
value in the Turkish localization entry to use sentence case, changing “Giriş
Yap” to “Giriş yap” while leaving the surrounding localization unchanged.
| actionLink: 'Bekleme listesine katıl', | ||
| actionText: 'Hala bir hesabınız yok mu?', | ||
| actionLink: 'Giriş Yap', | ||
| actionText: 'Hesabınız var mı?', |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Match the waitlist prompt to the base localization intent.
The base resource uses Already have access?, but Hesabınız var mı? asks whether the user has an account. These are different conditions. Use Zaten erişiminiz var mı? unless this locale-specific wording is intentional. (github.com)
As per path instructions: “Use the most up-to-date base localization file to validate changes, ensuring consistency and completeness.”
Proposed fix
- actionText: 'Hesabınız var mı?',
+ actionText: 'Zaten erişiminiz var mı?',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| actionText: 'Hesabınız var mı?', | |
| actionText: 'Zaten erişiminiz var mı?', |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/localizations/src/tr-TR.ts` at line 2222, Update the waitlist
prompt’s actionText in the Turkish localization to match the base resource’s
“Already have access?” intent by using “Zaten erişiminiz var mı?”.
Source: Path instructions
1 participant
Description
Waitlist actions were misleading. Action links to sign in page but the action text was "Still don't have an account?", and action link was "Join Waitlist". I changed them to match the behavior.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change