-
Notifications
You must be signed in to change notification settings - Fork 466
refactor(ui): rename Settings to Section #9428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| import * as SectionStories from './section.stories'; | ||
|
|
||
| # Section | ||
|
|
||
| A section component that carries the canonical heading, surface, row grouping, and item layout. Use it for product sections while composing each item's media, content, and actions as needed. | ||
|
|
||
| ## Usage | ||
|
|
||
| ```tsx | ||
| import { Section } from '@clerk/ui/mosaic/components/section'; | ||
|
|
||
| <Section.Root> | ||
| <Section.Title>Account</Section.Title> | ||
| <Section.Group> | ||
| <Section.Row> | ||
| <Section.Item> | ||
| <Section.Media>{icon}</Section.Media> | ||
| <Section.Content> | ||
| <Section.Label>Name</Section.Label> | ||
| <Section.Description>Shown throughout the application.</Section.Description> | ||
| </Section.Content> | ||
| <Section.Actions>{control}</Section.Actions> | ||
| </Section.Item> | ||
| </Section.Row> | ||
| </Section.Group> | ||
| </Section.Root> | ||
| ``` | ||
|
|
||
| `Section.Group` owns the outlined surface. Its direct `Section.Row` children own separation and may stack one or more `Section.Item` entries. Each item lays out optional media, flexible content, and trailing actions. `Section.Media` accepts `md` and `lg` sizes. | ||
|
|
||
| Use `Section.Items` for a nested value list beneath a row's header item. The row keeps an 8px header-to-list gap, nested items stack without gaps at a 44px minimum height, and their content receives 12px vertical padding. | ||
|
|
||
| ## Examples | ||
|
|
||
| <Story | ||
| name='Default' | ||
| storyModule={SectionStories} | ||
| composition={[ | ||
| { name: 'Avatar', href: '/components/avatar', layer: 'Components' }, | ||
| { name: 'Button', href: '/components/button', layer: 'Components' }, | ||
| ]} | ||
| /> | ||
|
|
||
| ### Multiple email addresses and phone numbers | ||
|
|
||
| <Story | ||
| name='MultipleEmailAndPhoneNumbers' | ||
| storyModule={SectionStories} | ||
| composition={[ | ||
| { name: 'Badge', href: '/components/badge', layer: 'Components' }, | ||
| { name: 'Button', href: '/components/button', layer: 'Components' }, | ||
| { name: 'Icon', href: '/components/icon', layer: 'Components' }, | ||
| ]} | ||
| /> | ||
|
|
||
| ### Connected accounts | ||
|
|
||
| <Story | ||
| name='ConnectedAccounts' | ||
| storyModule={SectionStories} | ||
| composition={[ | ||
| { name: 'Button', href: '/components/button', layer: 'Components' }, | ||
| { name: 'Icon', href: '/components/icon', layer: 'Components' }, | ||
| ]} | ||
| /> | ||
|
|
||
| ### Destructive section | ||
|
|
||
| <Story | ||
| name='Destructive' | ||
| storyModule={SectionStories} | ||
| /> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use the required compound-component page structure.
Sectionis a compound component. This page usesUsageandExamples, but it lacksExample,Parts, andStyling. Use the required order:Example,Usage,Parts, thenStyling.As per path instructions, “Compound Components pages must use the exact section order:
Example,Usage,Parts, thenStyling.”🤖 Prompt for AI Agents
Source: Path instructions