Skip to content

fix(astro,chrome-extension): Add missing Astro and Chrome Extension exports - #9434

Open
wobsoriano wants to merge 1 commit into
mainfrom
rob/fix-9425-9426
Open

fix(astro,chrome-extension): Add missing Astro and Chrome Extension exports#9434
wobsoriano wants to merge 1 commit into
mainfrom
rob/fix-9425-9426

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

Fixes #9425 and #9426.

Corrects the @clerk/astro/types export so it exposes the documented Clerk types.

Adds the documented @clerk/chrome-extension/legacy entry point for the legacy useSignIn() and useSignUp() hooks, including ESM, CommonJS, and TypeScript declarations.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 07a9c3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/chrome-extension Patch
@clerk/astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview Aug 13, 2026 4:17am
swingset Ready Ready Preview Aug 13, 2026 4:17am

Request Review

@wobsoriano wobsoriano changed the title fix(astro,chrome-extension): Add missing Astro and Chrome Extension e… fix(astro,chrome-extension): Add missing Astro and Chrome Extension exports Aug 13, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9434

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9434

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9434

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9434

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9434

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9434

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9434

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9434

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9434

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9434

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9434

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9434

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9434

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9434

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9434

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9434

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9434

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9434

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9434

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9434

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9434

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9434

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9434

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9434

commit: 07a9c3e

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-08-13T04:18:28.303Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 2
🔴 Breaking changes 1
🟡 Non-breaking changes 0
🟢 Additions 13

Warning
1 breaking change(s) detected - Major version bump required

🤖 This report was reviewed by claude-sonnet-4-6.

🔴 Breaking changes index (1)

Every breaking change, up front. Full diffs are in the package sections below.

Package Subpath Change
@clerk/astro ./types _default

@clerk/astro

Current version: 4.0.11
Recommended bump: MAJOR → 5.0.0

Subpath ./types

🔴 Breaking Changes (1)

Changed: _default
- _default: (params?: (import("./types").AstroClerkIntegrationParams & {
-     enableEnvSchema?: boolean;
- }) | undefined) => import("astro").AstroIntegration

Static analyzer: Removed function _default

🤖 AI review (confirmed) (95%): The _default export (the main integration factory function) has been removed entirely, so any consumer calling it will fail to compile.

Migration: Replace the removed _default import/call with the updated export name or alternative integration entry point provided in the new version of @clerk/astro.

🟢 Additions (12)

Click to expand 12 changes
Added: AstroClerkCreateInstanceParams
+ type AstroClerkCreateInstanceParams<TUi extends Ui = Ui> = AstroClerkIntegrationParams<TUi> & InternalClerkScriptProps & {
+     publishableKey: string;
+ };

Added type alias AstroClerkCreateInstanceParams

Added: AstroClerkIntegrationParams
+ type AstroClerkIntegrationParams<TUi extends Ui = Ui> = Without<ClerkOptions, 'isSatellite' | 'sdkMetadata' | 'standardBrowser' | 'selectInitialSession' | 'routerReplace' | 'routerDebug' | 'routerPush' | 'polling' | 'touchSession' | 'appearance'> & MultiDomainAndOrProxyPrimitives & {
+     appearance?: ExtractAppearanceType<TUi, Appearance>;
+     prefetchUI?: boolean;
+ };

Added type alias AstroClerkIntegrationParams

Added: AstroClerkUpdateOptions
+ type AstroClerkUpdateOptions<TUi extends Ui = Ui> = Pick<ClerkOptions, 'localization'> & {
+     appearance?: ExtractAppearanceType<TUi, Appearance>;
+ };

Added type alias AstroClerkUpdateOptions

Added: AstroMiddleware
+ export type AstroMiddleware = MiddlewareHandler;

Added type alias AstroMiddleware

Added: AstroMiddlewareContextParam
+ export type AstroMiddlewareContextParam = APIContext;

Added type alias AstroMiddlewareContextParam

Added: AstroMiddlewareNextParam
+ export type AstroMiddlewareNextParam = MiddlewareNext;

Added type alias AstroMiddlewareNextParam

Added: AstroMiddlewareReturn
+ export type AstroMiddlewareReturn = Response | Promise<Response>;

Added type alias AstroMiddlewareReturn

Added: AuthFn
+ export type AuthFn = GetAuthFnNoRequest<SessionAuthObjectWithRedirect>;

Added type alias AuthFn

Added: ButtonProps
+ export type ButtonProps = {
+     asChild?: boolean;
+ };

Added type alias ButtonProps

Added: InternalUIComponentId
+ export type InternalUIComponentId = 'sign-in' | 'sign-up' | 'create-organization' | 'organization-list' | 'organization-profile' | 'organization-switcher' | 'user-avatar' | 'user-button' | 'user-profile' | 'google-one-tap' | 'waitlist' | 'pricing-table' | 'api-keys';

Added type alias InternalUIComponentId

Added: ProtectProps
+ export type ProtectProps = ProtectParams;

Added type alias ProtectProps

Added: SessionAuthObjectWithRedirect
+ export type SessionAuthObjectWithRedirect = SessionAuthObject & {
+     redirectToSignIn: RedirectFun<Response>;
+ };

Added type alias SessionAuthObjectWithRedirect


@clerk/chrome-extension

Current version: 3.1.69
Recommended bump: MINOR → 3.2.0

Subpath ./legacy

🟢 Additions (1)

Added: ./legacy

New subpath export ./legacy


Report generated by Break Check

Last ran on 07a9c3e.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The changes correct the @clerk/astro/types declaration path. They add a public @clerk/chrome-extension/legacy entry point that re-exports useSignIn and useSignUp. The legacy entry point is included in the build and published files, with CommonJS, ESM, and TypeScript declaration metadata. Tests verify its exported names. Changesets document patch releases for both packages.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to 07a9c

The PR adds documented Astro and Chrome Extension exports. No actionable merge-blocking risk remains; the published subpath and generated declaration artifacts should receive routine follow-up coverage.

Possibly related issues

Suggested reviewers: dstaley

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Astro and Chrome Extension export fixes.
Description check ✅ Passed The description directly explains both export fixes and identifies the related issues.
Linked Issues check ✅ Passed The changes correct the @clerk/astro/types declaration path required by issue [#9425].
Out of Scope Changes check ✅ Passed All changes support the documented Astro and Chrome Extension export fixes, including tests and release changesets.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/chrome-extension/src/__tests__/exports.test.ts (1)

12-16: 🗄️ Data Integrity & Integration | 🔵 Trivial | 🏗️ Heavy lift

Cover the published subpath and emitted artifacts.

This test imports ../legacy, so it validates only the source re-export. It does not exercise @clerk/chrome-extension/legacy, the import and require conditions, or dist/types/legacy.d.ts. Add a package-level smoke and type-resolution test after the build.

As per coding guidelines, test files must include comprehensive unit, integration, and E2E coverage, and unit tests are required for all new functionality.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/chrome-extension/src/__tests__/exports.test.ts` around lines 12 -
16, Extend the legacy exports coverage beyond the source import by adding a
post-build package-level smoke test for `@clerk/chrome-extension/legacy` under
both import and require conditions, and verify that dist/types/legacy.d.ts
resolves the published type surface. Keep the existing legacyExports key
assertion, and run these checks against emitted artifacts rather than ../legacy.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@packages/chrome-extension/src/__tests__/exports.test.ts`:
- Around line 12-16: Extend the legacy exports coverage beyond the source import
by adding a post-build package-level smoke test for
`@clerk/chrome-extension/legacy` under both import and require conditions, and
verify that dist/types/legacy.d.ts resolves the published type surface. Keep the
existing legacyExports key assertion, and run these checks against emitted
artifacts rather than ../legacy.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 491a1ff1-efc2-417d-a38e-b64d12b5a21c

📥 Commits

Reviewing files that changed from the base of the PR and between 1447302 and 07a9c3e.

📒 Files selected for processing (8)
  • .changeset/add-chrome-extension-legacy.md
  • .changeset/fix-astro-types-export.md
  • packages/astro/package.json
  • packages/chrome-extension/legacy/package.json
  • packages/chrome-extension/package.json
  • packages/chrome-extension/src/__tests__/exports.test.ts
  • packages/chrome-extension/src/legacy.ts
  • packages/chrome-extension/tsup.config.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/clerk-ios (auto-detected)
  • clerk/cli (auto-detected)
  • clerk/clerk-android (auto-detected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@clerk/astro/types does not export documented Clerk types

1 participant