fix(astro,chrome-extension): Add missing Astro and Chrome Extension exports - #9434
fix(astro,chrome-extension): Add missing Astro and Chrome Extension exports#9434wobsoriano wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 07a9c3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
API Changes Report
Summary
🔴 Breaking changes index (1)Every breaking change, up front. Full diffs are in the package sections below.
@clerk/astroCurrent version: 4.0.11 Subpath
|
📝 WalkthroughWalkthroughThe changes correct the Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to The PR adds documented Astro and Chrome Extension exports. No actionable merge-blocking risk remains; the published subpath and generated declaration artifacts should receive routine follow-up coverage. Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/chrome-extension/src/__tests__/exports.test.ts (1)
12-16: 🗄️ Data Integrity & Integration | 🔵 Trivial | 🏗️ Heavy liftCover the published subpath and emitted artifacts.
This test imports
../legacy, so it validates only the source re-export. It does not exercise@clerk/chrome-extension/legacy, theimportandrequireconditions, ordist/types/legacy.d.ts. Add a package-level smoke and type-resolution test after the build.As per coding guidelines, test files must include comprehensive unit, integration, and E2E coverage, and unit tests are required for all new functionality.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/chrome-extension/src/__tests__/exports.test.ts` around lines 12 - 16, Extend the legacy exports coverage beyond the source import by adding a post-build package-level smoke test for `@clerk/chrome-extension/legacy` under both import and require conditions, and verify that dist/types/legacy.d.ts resolves the published type surface. Keep the existing legacyExports key assertion, and run these checks against emitted artifacts rather than ../legacy.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/chrome-extension/src/__tests__/exports.test.ts`:
- Around line 12-16: Extend the legacy exports coverage beyond the source import
by adding a post-build package-level smoke test for
`@clerk/chrome-extension/legacy` under both import and require conditions, and
verify that dist/types/legacy.d.ts resolves the published type surface. Keep the
existing legacyExports key assertion, and run these checks against emitted
artifacts rather than ../legacy.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 491a1ff1-efc2-417d-a38e-b64d12b5a21c
📒 Files selected for processing (8)
.changeset/add-chrome-extension-legacy.md.changeset/fix-astro-types-export.mdpackages/astro/package.jsonpackages/chrome-extension/legacy/package.jsonpackages/chrome-extension/package.jsonpackages/chrome-extension/src/__tests__/exports.test.tspackages/chrome-extension/src/legacy.tspackages/chrome-extension/tsup.config.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
clerk/clerk_go(manual)clerk/dashboard(manual)clerk/accounts(manual)clerk/backoffice(manual)clerk/clerk(manual)clerk/clerk-docs(manual)clerk/cloudflare-workers(manual)clerk/clerk-ios(auto-detected)clerk/cli(auto-detected)clerk/clerk-android(auto-detected)
Description
Fixes #9425 and #9426.
Corrects the
@clerk/astro/typesexport so it exposes the documented Clerk types.Adds the documented
@clerk/chrome-extension/legacyentry point for the legacyuseSignIn()anduseSignUp()hooks, including ESM, CommonJS, and TypeScript declarations.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change