Skip to content

Pin REST API version to 2022-11-28 #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williammartin merged 2 commits into from
Feb 13, 2026
Merged

Pin REST API version to 2022-11-28 #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d63aec
Pin REST API version to 2022-11-28
williammartin Feb 13, 2026
1ea5889
Rename resolveHeaders to setDefaultHeaders
williammartin Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pkg/api/http_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ import (
const (
accept = "Accept"
authorization = "Authorization"
apiVersion = "X-GitHub-Api-Version"
apiVersionValue = "2022-11-28"
contentType = "Content-Type"
github = "github.com"
jsonContentType = "application/json; charset=utf-8"
Expand Down Expand Up @@ -112,7 +114,7 @@ func NewHTTPClient(opts ClientOptions) (*http.Client, error) {
opts.Headers = map[string]string{}
}
if !opts.SkipDefaultHeaders {
resolveHeaders(opts.Headers)
setDefaultHeaders(opts.Headers)
}
transport = newHeaderRoundTripper(opts.Host, opts.AuthToken, opts.Headers, transport)

Expand Down Expand Up @@ -141,7 +143,7 @@ type headerRoundTripper struct {
rt http.RoundTripper
}

func resolveHeaders(headers map[string]string) {
func setDefaultHeaders(headers map[string]string) {
if _, ok := headers[contentType]; !ok {
headers[contentType] = jsonContentType
}
Expand All @@ -163,6 +165,9 @@ func resolveHeaders(headers map[string]string) {
headers[timeZone] = tz
}
}
if _, ok := headers[apiVersion]; !ok {
headers[apiVersion] = apiVersionValue
}
if _, ok := headers[accept]; !ok {
// Preview for PullRequest.mergeStateStatus.
a := "application/vnd.github.merge-info-preview+json"
Expand Down
2 changes: 2 additions & 0 deletions pkg/api/http_client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ func TestNewHTTPClient(t *testing.T) {
wantHeaders: func() http.Header {
h := defaultHeaders()
h.Del(accept)
h.Del(apiVersion)
h.Del(contentType)
h.Del(timeZone)
h.Del(userAgent)
Expand Down Expand Up @@ -169,6 +170,7 @@ func defaultHeaders() http.Header {
h := http.Header{}
a := "application/vnd.github.merge-info-preview+json"
a += ", application/vnd.github.nebula-preview"
h.Set(apiVersion, apiVersionValue)
h.Set(contentType, jsonContentType)
h.Set(userAgent, "go-gh")
h.Set(authorization, fmt.Sprintf("token %s", "oauth_token"))
Expand Down
Loading