Fix broken value method call for Rails 5.2 regarding ActionView Tags#8
Open
nimashariatian wants to merge 1 commit intocllns:masterfrom
Open
Fix broken value method call for Rails 5.2 regarding ActionView Tags#8nimashariatian wants to merge 1 commit intocllns:masterfrom
nimashariatian wants to merge 1 commit intocllns:masterfrom
Conversation
Author
|
@cllns any feedback on this PR? |
Author
|
let me know if you would like this to be done in another branch, but considering how it's such a minor update, i did it on master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi guys,
this PR fixes an issue for Rails 5.2 regarding ActionView::Tags::Base
the following code:
subdivision_select/lib/subdivision_select/tag_helper.rb
Lines 5 to 8 in 5323418
fails as value isn't called with any arguments from rails tag methods, eg:
https://github.com/rails/rails/blob/659c516bef2781cc66865fc78ed5dce682566d26/actionview/lib/action_view/helpers/tags/base.rb#L53
object is available here, so shouldn't need to be passed as an arg:
https://github.com/rails/rails/blob/659c516bef2781cc66865fc78ed5dce682566d26/actionview/lib/action_view/helpers/tags/base.rb#L10