Skip to content

Disable overwrite flag during cloudbase-init installation #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dany9966 merged 2 commits into from
Nov 25, 2025
Merged

Disable overwrite flag during cloudbase-init installation #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
219c70d
Disable `overwrite` flag when extracting `cloudbase-init`
mihaelabalutoiu Nov 21, 2025
24a44af
Update `unit tests`
mihaelabalutoiu Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coriolis/osmorphing/windows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ def _install_cloudbase_init(self, download_url,

self._event_manager.progress_update("Installing cloudbase-init")
self._expand_archive(cloudbaseinit_zip_path,
cloudbaseinit_base_dir)
cloudbaseinit_base_dir, overwrite=False)

log_dir = "%s\\Log" % cloudbaseinit_base_dir
self._conn.exec_ps_command("mkdir '%s' -Force" % log_dir,
Expand Down
6 changes: 4 additions & 2 deletions coriolis/tests/osmorphing/test_windows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,8 @@ def test__install_cloudbase_init(
"%sWindows\\System32\\config\\SYSTEM" % self.os_root_dir)

mock_expand_archive.assert_called_once_with(
cloudbaseinit_zip_path, cloudbaseinit_base_dir)
cloudbaseinit_zip_path, cloudbaseinit_base_dir,
overwrite=False)

self.conn.exec_ps_command.assert_called_once_with(
"mkdir '%s' -Force" %
Expand Down Expand Up @@ -625,7 +626,8 @@ def test_install_cloudbase_init_existing_service(
"HKLM\\%s" % mock_uuid4.return_value,
"%sWindows\\System32\\config\\SYSTEM" % self.os_root_dir)
mock_expand_archive.assert_called_once_with(
cloudbaseinit_zip_path, cloudbaseinit_base_dir)
cloudbaseinit_zip_path, cloudbaseinit_base_dir,
overwrite=False)
self.conn.exec_ps_command.assert_called_once_with(
"mkdir '%s' -Force" %
("%s\\Log" % cloudbaseinit_base_dir),
Expand Down