Serialize empty attribute values without =""#325
Open
gjtorikian wants to merge 1 commit into
Open
Conversation
gjtorikian
requested review from
a team,
Noah-Kennedy,
jasnell and
orium
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Element::set_attributeis called with an empty value, emit the attribute as a valueless attribute (e.g.<p data-thing>) rather than<p data-thing="">.The two are equivalent per the HTML spec, but the valueless form is what callers asking for "add a boolean attribute" expect to see in the output. Original raw attributes from the input are still emitted verbatim, so this only affects programmatically added/modified attributes.
Closes #205.