feat: implement maximum participants limit#157
Open
dev-kraken wants to merge 1 commit intocloudflare:mainfrom
Open
feat: implement maximum participants limit#157dev-kraken wants to merge 1 commit intocloudflare:mainfrom
dev-kraken wants to merge 1 commit intocloudflare:mainfrom
Conversation
- Add MAX_PARTICIPANTS environment variable in wrangler.toml - Update loader to parse and validate MAX_PARTICIPANTS - Modify Lobby component to use maxParticipants for determining room capacity - Implement UI changes to show when a room is full and prevent joining - Handle cases where MAX_PARTICIPANTS is not set or invalid
Collaborator
|
Hey @dev-kraken thanks for the PR. There are some changes I'm going to make before merging this — I think I'll likely keep your commit and create a new branch/PR from it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Maximum Participants Limit
This PR introduces a feature to limit the number of participants in a room.
Changes
MAX_PARTICIPANTSenvironment variable inwrangler.tomlfor exampleMAX_PARTICIPANTS = 10MAX_PARTICIPANTSmaxParticipantsfor determining room capacityHow to test
MAX_PARTICIPANTSinwrangler.tomlNotes for reviewers
MAX_PARTICIPANTSvalues is sufficientMAX_PARTICIPANTSis not set or invalidclose #140