Skip to content

fix(microfrontend-template): pass through WebSocket upgrade responses as-is #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seivad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(microfrontend-template): pass through WebSocket upgrade responses as-is #964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions microfrontend-template/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,6 +869,14 @@ async function handleMountedApp(
const upstreamResp = await upstream.fetch(
new Request(forwardUrl.toString(), request),
);

// WebSocket upgrades must be returned as-is — do not wrap in a new Response,
// as that would strip the WebSocket pair from the response and break the connection.
// This applies to Durable Objects, Agents SDK, PartyKit, and any other WebSocket upgrade.
if (upstreamResp.status === 101) {
return upstreamResp;
}

const headers = new Headers(upstreamResp.headers);
const contentType = headers.get("content-type") || "";

Expand Down