Fix WABT dependency

[logan-gatlin]

My last PR messed up the WABT dependency and added a dependency to wasm-tools incorrectly. This reverts that mistake

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

This PR adds a deps_wabt entry to build_deps.jsonc to fix a dependency issue from PR #6154. However, there are several problems that need to be addressed:

1. [HIGH] Missing BUILD.wabt file — The entry references "build_file": "//:build/BUILD.wabt" but this file does not exist anywhere in the repository. Running update-deps.py will fail or produce a broken dependency.

2. [HIGH] deps_wabt is not referenced anywhere — No BUILD.bazel, .bzl, or MODULE.bazel file in the repo references deps_wabt or @deps_wabt. This dependency will be fetched but never used.

3. [HIGH] wasm-tools source entries still missing from build_deps.jsonc — The actual problem from PR #6154 is that wasm-tools entries were hand-edited into the generated gen/build_deps.MODULE.bazel without corresponding entries in build_deps.jsonc. These wasm-tools entries ARE actively used by tools/BUILD.bazel and build/wasm_tools_parse.bzl. Running update-deps.py after this PR will remove the wasm-tools entries from the generated file (since they have no source in the jsonc) and break the build.

4. [MEDIUM] Generated file not regenerated — build_deps.MODULE.bazel is not updated in this PR. You'll need to run update-deps.py to regenerate it after fixing the jsonc source entries.

It looks like this PR adds the wrong dependency (wabt instead of wasm-tools) and is missing the BUILD.wabt file it references. The real fix likely needs to add wasm-tools source entries to build_deps.jsonc (one per platform, matching what's currently hand-edited in gen/build_deps.MODULE.bazel), and then regenerate the generated file.

---

This review was written by an AI assistant and may contain errors. Please verify the findings independently.

[ask-bonk]

Several issues with this entry:

1. build_file references a non-existent file: //:build/BUILD.wabt does not exist in the repo. This was not added in this PR or in PR Signal handling for non-Python WASM modules #6154.

2. deps_wabt is unused: No BUILD file or .bzl rule in the repo references @deps_wabt. The dependency that IS actively used is wasm-tools (referenced by tools/BUILD.bazel and build/wasm_tools_parse.bzl).

3. The wasm-tools entries in gen/build_deps.MODULE.bazel are still orphaned: They were hand-edited into the generated file by PR Signal handling for non-Python WASM modules #6154 without corresponding source entries here. Running update-deps.py after this PR will delete them and break the build.

I believe the fix should instead add source entries for wasm-tools (one per platform: wasm_tools_linux_x64, wasm_tools_linux_arm64, wasm_tools_macos_x64, wasm_tools_macos_arm64, wasm_tools_windows_x64) to match what's currently in gen/build_deps.MODULE.bazel, and then regenerate the generated file. If wabt is also needed, you'll need to create the BUILD.wabt file and add a reference to @deps_wabt in the appropriate BUILD file.

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

This PR adds a deps_wabt entry to build_deps.jsonc, but there are several high-severity issues:

1. Missing BUILD.wabt file — The build_file references //:build/BUILD.wabt which doesn't exist in the repo.

2. deps_wabt is unused — Nothing in the codebase references @deps_wabt. The dependency that IS actively used is wasm-tools (via tools/BUILD.bazel and build/wasm_tools_parse.bzl).

3. wasm-tools source entries still missing — PR Signal handling for non-Python WASM modules #6154 hand-edited wasm-tools entries into the generated gen/build_deps.MODULE.bazel without adding corresponding entries to build_deps.jsonc. Those entries are the ones that need source definitions. Running update-deps.py after this PR will delete the wasm-tools entries and break the build.

4. Generated file not regenerated — build_deps.MODULE.bazel needs to be regenerated after fixing the source entries.

The review has been posted to the PR.

github run

[codspeed-hq]

Merging this PR will improve performance by 12.81%

⚡ 1 improved benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks¹

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
⚡	Encode_ASCII_32[TextEncoder][0/0/32]	3.5 ms	3.1 ms	+12.81%

---

_{Comparing logan/revert-wabt-dep (a3b81b7) with main (b93e3b5)}

Footnotes

1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[logan-gatlin]

Misunderstood what the actual issue was