Open
Conversation
Merging this PR will not alter performance
|
fbc27ef to
ef8c6e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
Signalstruct which represents and interprets signals received by the runtime. Currently, signals require compiling with "panic=unwind", and are not supported in miniflare. I added the tests anyway, including a new test suite for panic=unwind tests as I presume we will want to write more of those in the future. The example code I added is deployed here: https://pi.logan.md/, confirming that the new API does work in production. We may want to wait for miniflare to catch up and signal support for panic=abort to land before merging this.This PR bumps most of our dependencies by a significant amount which is something to keep in mind.