Add validation for the signatures of functions annotated with #[event(fetch)], #[event(start)] etc.#940
Open
jakubadamw wants to merge 3 commits intocloudflare:mainfrom
Conversation
Add compile-time validation for all four event handler types to catch signature mismatches early with clear error messages: - fetch: must be async, exactly 3 params (request, env, ctx) - scheduled: must be async, exactly 3 params (event, env, ctx) - queue: must be async, exactly 3 params (message_batch, env, ctx) - start: must not be async, exactly 0 params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses an old TODO by having the signatures for user-defined event handlers be validated at the proc macro expansion stage to avoid having the errors crop up during type check of the expanded code in a form that wasn't exactly always very clear, like so:
WIth this change the macro reports:
I also added a few tests using the trybuild crate.