Skip to content

Fixed leptos template#945

Merged
guybedford merged 2 commits intocloudflare:mainfrom
Sushi-Mampfer:main
Mar 11, 2026
Merged

Fixed leptos template#945
guybedford merged 2 commits intocloudflare:mainfrom
Sushi-Mampfer:main

Conversation

@Sushi-Mampfer
Copy link
Contributor

This is tested on windows and kali linux(I had a vm laying around, don't judge me), I'm unable to test on macos, but I doubt that there will be any issues.

getrandom 0.3 and 0.4 are a transitive dependency, but they don't have the was_js feature enabled by default
Comment on lines +18 to +19
getrandom = { version = "0.4", features = ["wasm_js"]}
getrandom03 = { package = "getrandom", version = "0.3", features = ["wasm_js"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for the 0.4 bump here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leptos uses 0.3, but leptos_macros use 0.4. And both need the wasm_js feature to be compiled to wasm. Which version is the "man" getrandom and which the secondary doesn't matter, but I thought that using the newer version would be better better. And I don't see a reason why this would cause any breaking changes.

PS C:\Users\sushi\rust\test2> cargo tree -i getrandom@0.3.4 --features ssr
getrandom v0.3.4
├── rand_core v0.9.5
│   ├── rand v0.9.2
│   │   └── leptos v0.8.17
│   │       ├── leptos_axum v0.8.8
│   │       │   └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
│   │       ├── leptos_integration_utils v0.8.8
│   │       │   └── leptos_axum v0.8.8 (*)
│   │       ├── leptos_meta v0.8.6
│   │       │   ├── leptos_axum v0.8.8 (*)
│   │       │   ├── leptos_integration_utils v0.8.8 (*)
│   │       │   └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
│   │       ├── leptos_router v0.8.12
│   │       │   ├── leptos_axum v0.8.8 (*)
│   │       │   ├── leptos_integration_utils v0.8.8 (*)
│   │       │   └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
│   │       └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
│   └── rand_chacha v0.9.0
│       └── rand v0.9.2 (*)
└── test2 v0.1.0 (C:\Users\sushi\rust\test2)
PS C:\Users\sushi\rust\test2> cargo tree -i getrandom@0.4.2 --features ssr
getrandom v0.4.2
└── uuid v1.22.0
    └── leptos_macro v0.8.15 (proc-macro)
        ├── leptos v0.8.17
        │   ├── leptos_axum v0.8.8
        │   │   └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
        │   ├── leptos_integration_utils v0.8.8
        │   │   └── leptos_axum v0.8.8 (*)
        │   ├── leptos_meta v0.8.6
        │   │   ├── leptos_axum v0.8.8 (*)
        │   │   ├── leptos_integration_utils v0.8.8 (*)
        │   │   └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
        │   ├── leptos_router v0.8.12
        │   │   ├── leptos_axum v0.8.8 (*)
        │   │   ├── leptos_integration_utils v0.8.8 (*)
        │   │   └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
        │   └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
        └── leptos_axum v0.8.8 (*)

getrandom v0.4.2
├── leptos v0.8.17 (*)
└── test2 v0.1.0 (C:\Users\sushi\rust\test2)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming. That is indeed unfortunate, hopefully this can resolve soon. Will land in the meantime.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 11, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 2 untouched benchmarks


Comparing Sushi-Mampfer:main (46bc1af) with main (652cd4b)

Open in CodSpeed

@guybedford guybedford merged commit 2d022ab into cloudflare:main Mar 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants