Conversation
getrandom 0.3 and 0.4 are a transitive dependency, but they don't have the was_js feature enabled by default
| getrandom = { version = "0.4", features = ["wasm_js"]} | ||
| getrandom03 = { package = "getrandom", version = "0.3", features = ["wasm_js"] } |
There was a problem hiding this comment.
What is the reason for the 0.4 bump here?
There was a problem hiding this comment.
leptos uses 0.3, but leptos_macros use 0.4. And both need the wasm_js feature to be compiled to wasm. Which version is the "man" getrandom and which the secondary doesn't matter, but I thought that using the newer version would be better better. And I don't see a reason why this would cause any breaking changes.
PS C:\Users\sushi\rust\test2> cargo tree -i getrandom@0.3.4 --features ssr
getrandom v0.3.4
├── rand_core v0.9.5
│ ├── rand v0.9.2
│ │ └── leptos v0.8.17
│ │ ├── leptos_axum v0.8.8
│ │ │ └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
│ │ ├── leptos_integration_utils v0.8.8
│ │ │ └── leptos_axum v0.8.8 (*)
│ │ ├── leptos_meta v0.8.6
│ │ │ ├── leptos_axum v0.8.8 (*)
│ │ │ ├── leptos_integration_utils v0.8.8 (*)
│ │ │ └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
│ │ ├── leptos_router v0.8.12
│ │ │ ├── leptos_axum v0.8.8 (*)
│ │ │ ├── leptos_integration_utils v0.8.8 (*)
│ │ │ └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
│ │ └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
│ └── rand_chacha v0.9.0
│ └── rand v0.9.2 (*)
└── test2 v0.1.0 (C:\Users\sushi\rust\test2)
PS C:\Users\sushi\rust\test2> cargo tree -i getrandom@0.4.2 --features ssr
getrandom v0.4.2
└── uuid v1.22.0
└── leptos_macro v0.8.15 (proc-macro)
├── leptos v0.8.17
│ ├── leptos_axum v0.8.8
│ │ └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
│ ├── leptos_integration_utils v0.8.8
│ │ └── leptos_axum v0.8.8 (*)
│ ├── leptos_meta v0.8.6
│ │ ├── leptos_axum v0.8.8 (*)
│ │ ├── leptos_integration_utils v0.8.8 (*)
│ │ └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
│ ├── leptos_router v0.8.12
│ │ ├── leptos_axum v0.8.8 (*)
│ │ ├── leptos_integration_utils v0.8.8 (*)
│ │ └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
│ └── test2 v0.1.0 (C:\Users\sushi\rust\test2)
└── leptos_axum v0.8.8 (*)
getrandom v0.4.2
├── leptos v0.8.17 (*)
└── test2 v0.1.0 (C:\Users\sushi\rust\test2)
There was a problem hiding this comment.
Thanks for confirming. That is indeed unfortunate, hopefully this can resolve soon. Will land in the meantime.
Merging this PR will not alter performance
|
This is tested on windows and kali linux(I had a vm laying around, don't judge me), I'm unable to test on macos, but I doubt that there will be any issues.