Add get_bulk support to KV store bindings#949
Open
rorychatterton wants to merge 1 commit intocloudflare:mainfrom
Open
Add get_bulk support to KV store bindings#949rorychatterton wants to merge 1 commit intocloudflare:mainfrom
rorychatterton wants to merge 1 commit intocloudflare:mainfrom
Conversation
Add KvStore::get_bulk() for fetching multiple keys in a single call, using the existing JS runtime bulk get API. Returns HashMap<String, Option<T>> via a GetBulkOptionsBuilder with text(), json(), text_with_metadata(), and json_with_metadata() terminal methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
The Workers KV JS runtime already accepts an array of keys in get() and getWithMetadata(), returning a JS Map. This adds Rust bindings for that, passing a js_sys::Array instead of a single string and iterating the returned Map into a HashMap<String, Option>.
No new JS bindings are needed — reuses the existing get_function and get_with_meta_function references on KvStore.
To test it, I ran it locally with miniflare on my app and seemed to be fine.