[wrangler] fix: remove stale --experimental-vm-modules flag and prevent silent exits#14306
[wrangler] fix: remove stale --experimental-vm-modules flag and prevent silent exits#14306matingathani wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: f107c99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
penalosa
and removed request for
a team
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
- Remove fix: prefix from changeset title (Devin) - Rewrite changeset body to focus on user-facing impact, not implementation details (Devin) - Update AGENTS.md to remove stale --experimental-vm-modules reference (Devin) - Capture handleError exception in catch block, include in stderr fallback (Copilot) - Use e.stack ?? e.message for more informative fallback output (Copilot)
…t silent exits Remove `--experimental-vm-modules` from the child process spawn args in `bin/wrangler.js`. This flag was deprecated when `vm.Module` became stable in Node.js v22, and `wrangler-dist/cli.js` makes zero use of VM Modules. The stale flag causes unexpected behaviour on Node.js v26, where users see wrangler silently exit with code 1 after printing the banner. Also wrap the `handleError()` call in a try-catch so that if `handleError()` itself throws, the original error message is written directly to stderr. Previously, `handleError()` exceptions were silently swallowed by the top-level `.catch()` in `cli.ts`, producing a silent exit with code 1. Fixes cloudflare#14296
- Remove fix: prefix from changeset title (Devin) - Rewrite changeset body to focus on user-facing impact, not implementation details (Devin) - Update AGENTS.md to remove stale --experimental-vm-modules reference (Devin) - Capture handleError exception in catch block, include in stderr fallback (Copilot) - Use e.stack ?? e.message for more informative fallback output (Copilot)
petebacondarwin
force-pushed
the
fix/node-v26-silent-exit
branch
from
f107c99 to
b439e13
Compare
| "wrangler": patch | ||
| --- | ||
|
|
||
| Remove deprecated `--experimental-vm-modules` flag and prevent silent exit on unexpected errors |
There was a problem hiding this comment.
🟡 Changeset title includes internal implementation detail (--experimental-vm-modules)
Per REVIEW.md: "Changesets should target users of the tools (e.g. Wrangler users) rather than maintainers. Avoid including implementation details like 'moves X from hybridModules to nativeModules' or 'removes polyfill implementation'." The changeset title "Remove deprecated --experimental-vm-modules flag and prevent silent exit on unexpected errors" mentions --experimental-vm-modules, an internal Node.js flag passed by the bin/wrangler.js shim that users never see or interact with. A more user-focused title would be something like "Fix silent exit with no error message on Node.js v26".
| Remove deprecated `--experimental-vm-modules` flag and prevent silent exit on unexpected errors | |
| Fix silent exit with no error message on Node.js v26 |
Was this helpful? React with 👍 or 👎 to provide feedback.
|
As far as I can tell https://nodejs.org/docs/latest-v26.x/api/vm.html#class-vmmodule |
Fixes #14296.
Two issues caused
wranglerto silently exit with code 1 on Node.js v26 with no error message:bin/wrangler.jswas passing--experimental-vm-modulesto the child process. This flag was deprecated whenvm.Modulebecame stable in Node.js v22, and the compiledwrangler-dist/cli.jsdoes not use VM Modules. On Node.js v26, the stale flag triggers unexpected behaviour.If
handleError()itself throws (e.g. during config parsing before it can log the original error), the exception was silently swallowed by the top-level.catch()incli.tswhich just callsprocess.exit(exitCode)with no output. WrappinghandleError()in a try-catch ensures the user always sees the original error message on stderr.--experimental-vm-modulesremoval is a no-op for Node.js < v26 (the flag was simply accepted and ignored), and the try-catch fallback only activates whenhandleError()itself throws which is an abnormal internal error path. Manual verification on Node.js v26 confirms the fix.