CI: add windows testing and linting to Go workflow #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctlong
force-pushed
the
ci/go-workflow-includes-windows
branch
3 times, most recently
from
a4d985e to
7488379
Compare
We should test the blackbox code for all the cases where it will be used: * as a linux binary in the syslog-release * as a windows binary in the windows-syslog-release
* the subdirectory/filename tag in Windows has a different separator, match on both that and the linux separator. * The trailing space appears to be removed by `os.Mkdir()` on Windows, remove it to make that test pass, as we already test that a space is ignored earlier in that string.
ctlong
force-pushed
the
ci/go-workflow-includes-windows
branch
from
7488379 to
d9bc505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since windows-syslog release compiles and runs the blackbox process in Windows VMs, we should also test and lint the process in Windows VMs.