[Sealights][SLDEV-22556] - update documentation#336
Open
yishayh wants to merge 1 commit intocloudfoundry:masterfrom
Open
[Sealights][SLDEV-22556] - update documentation#336yishayh wants to merge 1 commit intocloudfoundry:masterfrom
yishayh wants to merge 1 commit intocloudfoundry:masterfrom
Conversation
A short explanation of the proposed change:
Extend the Sealights integration to support injection into any npm script command, not just npm start. This will enable support for commands like npm run start-dev, npm run dev, npm run server, etc.
An explanation of the use cases your change solves
It will be possible to define run command for injection as npmRunScript parameter
VCAP_SERVICES
{
"user-provided": [{
"name": "sealights-service",
"credentials": {
"token": "xxx",
"buildSessionId": "xxx",
"npmRunScript": "start-dev"
}
}]
}
If it is not provided Sealight will be injected into start command for backward compatibility.
|
3 tasks
|
it seems you commited this with either the wrong name or you have not signed the cla yet (you can press the big red button) for signing |
Author
|
Thank @ramonskie , can you tell me who to enter as the CLA manager (For Tricentis)? |
|
i would just put it on your personal account. as that would be the most easy |
Author
|
@ramonskie I'll need to approve it internally in Tricentis, I'll keep you posted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Extend the Sealights integration to support injection into any npm script command, not just npm start. This will enable support for commands like npm run start-dev, npm run dev, npm run server, etc.
An explanation of the use cases your change solves It will be possible to define run command for injection as npmRunScript parameter
If it is not provided Sealight will be injected into start command for backward compatibility.