Skip to content

Add support to mount secrets and do not use ARGs for secrets as they … #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eduartua wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support to mount secrets and do not use ARGs for secrets as they … #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/build-docker-push-to-ecr-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ on:
AWS_ROLE_NAME:
required: true
type: string
BUILD_ARGS:
required: false
type: string
BUILD_SECRETS:
required: false
type: string
description: "Docker build secret flags, e.g., --secret id=TOKEN1,env=SECRET1 --secret id=TOKEN2,env=SECRET2"
DOCKERFILE_NAME:
required: false
type: string
Expand All @@ -32,10 +39,6 @@ on:
type: boolean
default: true

secrets:
BUILD_ARG:
required: false

jobs:
docker:
runs-on: ubuntu-latest
Expand All @@ -61,7 +64,7 @@ jobs:
docker build -f ${{ inputs.DOCKERFILE_NAME }} \
-t ${{ inputs.REGISTRY_URL }}/${{ inputs.APPLICATION_NAME }}:$GITHUB_SHA \
${{ inputs.BUILD_ARGS }} \
${{ secrets.BUILD_ARG }} \
${{ inputs.BUILD_SECRETS }} \
.
docker push -a ${{ inputs.REGISTRY_URL }}/${{ inputs.APPLICATION_NAME }}
- name: Retag and push container image
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-docker-push-to-ecr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ on:
BUILD_ARGS:
required: false
type: string
BUILD_SECRETS:
required: false
type: string
description: "Docker build secret flags, e.g., --secret id=TOKEN1,env=SECRET1 --secret id=TOKEN2,env=SECRET2"
DOCKERFILE_NAME:
required: false
type: string
Expand All @@ -35,10 +39,6 @@ on:
type: boolean
default: true

secrets:
BUILD_ARG:
required: false

jobs:
docker:
runs-on: ubuntu-latest
Expand All @@ -64,7 +64,7 @@ jobs:
docker build -f ${{ inputs.DOCKERFILE_NAME }} \
-t ${{ inputs.REGISTRY_URL }}/${{ inputs.APPLICATION_NAME }}:$GITHUB_SHA \
${{ inputs.BUILD_ARGS }} \
${{ secrets.BUILD_ARG }} \
${{ inputs.BUILD_SECRETS }} \
.
docker push -a ${{ inputs.REGISTRY_URL }}/${{ inputs.APPLICATION_NAME }}
- name: Retag and push container image
Expand Down