Feat/thanos add self monitor flag#1461
Open
sjentzschsap wants to merge 4 commits intocloudoperators:mainfrom
Open
Feat/thanos add self monitor flag#1461sjentzschsap wants to merge 4 commits intocloudoperators:mainfrom
sjentzschsap wants to merge 4 commits intocloudoperators:mainfrom
Conversation
Contributor
|
can we have a more standard spec for that?
|
Contributor
|
This PR is stale because it has been open for 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Provide details about your pull request and what it adds, fixes, or changes.
Allow to disable deployment of PrometheusRules even when ServiceMonitor is wanted
Breaking Changes
Describe what features are broken by this pull request and why, if any.
none
Issues Fixed
Enter the issue numbers resolved by this pull request below, if any.
SAP-internal tickets; no need to post them here I guess
Other Relevant Information
Provide any other important details below.
As aligned