refactor:don't throw error when adding existing relations by Aliexe-code · Pull Request #1076 · cloudoperators/heureka

Aliexe-code · 2026-02-05T11:05:25Z

Title:
refactor: don't throw error when adding existing relations

Description
If the relation already exists, don't throw an error message. This prevents polluting our logs with duplicate entry errors.
Modified 5 Add* functions to return nil instead of error when relation already exists:

Related Tickets & Documents
Fixes #1057
Added tests?

michalkrzyz · 2026-02-05T12:15:38Z

internal/database/mariadb/support_group.go

-
-	return err
+	if err != nil {
+		if strings.Contains(err.Error(), "Error 1062") || strings.Contains(err.Error(), "Duplicate entry") {


Why can't we use this:

_, err := sqlExec(s, query, args, l) if err != nil { var mysqlErr *mysql.MySQLError if errors.As(err, &mysqlErr) && mysqlErr.Number == 1062 { return nil // duplicate entry } return err }

If the relation already exists, don't throw an error message. This prevents polluting logs with duplicate entry errors Fixes cloudoperators#1057

MR2011 · 2026-02-06T09:38:35Z

internal/database/mariadb/service.go

-
-	return err
+	if err != nil {
+		if strings.Contains(err.Error(), "Error 1062") || strings.Contains(err.Error(), "Duplicate entry") {


The same errors.As() approach can be used here as well

MR2011 · 2026-02-06T09:38:50Z

internal/database/mariadb/support_group.go

-
-	return err
+	if err != nil {
+		if strings.Contains(err.Error(), "Error 1062") || strings.Contains(err.Error(), "Duplicate entry") {


The same errors.As() approach can be used here as well

Replace strings.Contains() with errors.As() for more robust MySQL error handling when detecting duplicate entry errors (error code 1062). Addresses reviewer feedback from cloudoperators#1076

MR2011 · 2026-02-06T12:37:55Z

After looking at this again, I suggest using the DuplicateEntryDatabaseError. Here's an example how to use it.

When removing a relation, a duplicate error won't happen, so we don't need to add the check there. There might be a Not Found error, but for now it's not required to check for this.

…etection Replace strings.Contains() and errors.As() with strings.HasPrefix() for MySQL duplicate entry detection and return DuplicateEntryDatabaseError when a duplicate is detected, following the pattern in component_version.go. This allows handlers to catch and handle duplicate entries gracefully with user-friendly error messages instead of logging raw MySQL errors. Addresses reviewer feedback from cloudoperators#1076

Copilot

Pull request overview

This PR aims to make “Add* relation” operations idempotent by avoiding errors/log noise when a relation already exists (Fixes #1057).

Changes:

Added duplicate-key detection for several relation insert operations.
Introduced database.NewDuplicateEntryDatabaseError(...) returns for duplicate relations.
Updated duplicate detection logic in AddComponentVersionToIssue.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
internal/database/mariadb/support_group.go	Adds duplicate handling in support-group relation insert helpers (currently introduces missing import + still returns an error on duplicates).
internal/database/mariadb/service.go	Adds duplicate handling in service relation insert helpers (currently introduces missing import + still returns an error on duplicates).
internal/database/mariadb/issue.go	Adjusts duplicate handling for issue ↔ component version relation insert (still returns an error on duplicates).

Comments suppressed due to low confidence (2)

internal/database/mariadb/support_group.go:13

strings.HasPrefix is used in this file, but strings is not imported in the import block. This will not compile; add the missing strings import (or avoid using strings.*).

import (
	"fmt"

	"github.com/cloudoperators/heureka/internal/database"
	"github.com/cloudoperators/heureka/internal/entity"
	"github.com/samber/lo"
	"github.com/sirupsen/logrus"
)

internal/database/mariadb/service.go:13

strings.HasPrefix is used in this file, but strings is not imported in the import block. This will not compile; add the missing strings import (or avoid using strings.*).

import (
	"fmt"

	"github.com/cloudoperators/heureka/internal/database"
	"github.com/cloudoperators/heureka/internal/entity"
	"github.com/samber/lo"
	"github.com/sirupsen/logrus"
)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-20T13:48:55Z

internal/database/mariadb/service.go

+	if err != nil {
+		if strings.HasPrefix(err.Error(), "Error 1062") {
+			return database.NewDuplicateEntryDatabaseError(fmt.Sprintf("IssueRepository %d already associated with Service %d", issueRepositoryId, serviceId))
+		}


This function still returns a DuplicateEntryDatabaseError on duplicate relations. Per the PR/issue goal (“don't throw error when adding existing relations”), duplicates should be treated as a no-op and return nil here (otherwise callers will continue to handle/log it as an error).

Copilot · 2026-03-20T13:48:55Z

internal/database/mariadb/issue.go

 	if err != nil {
-		// Replace string-based error detection with proper error type checking
-		if strings.Contains(err.Error(), "Error 1062") || strings.Contains(err.Error(), "Duplicate entry") {
-			return database.NewDuplicateEntryDatabaseError(fmt.Sprintf("ComponentVersion %d already associated with Issue %d", componentVersionId, issueId))
+		if strings.HasPrefix(err.Error(), "Error 1062") {
+			return database.NewDuplicateEntryDatabaseError(fmt.Sprintf("Issue %d already associated with ComponentVersion %d", issueId, componentVersionId))
 		}


This function still returns a DuplicateEntryDatabaseError on duplicate relations. Per the PR/issue goal (“don't throw error when adding existing relations”), duplicates should be treated as a no-op and return nil instead; otherwise the handler layer will continue to treat/log this as an error.

Copilot · 2026-03-20T13:48:55Z

internal/database/mariadb/support_group.go

+	if err != nil {
+		if strings.HasPrefix(err.Error(), "Error 1062") {
+			return database.NewDuplicateEntryDatabaseError(fmt.Sprintf("Service %d already in SupportGroup %d", serviceId, supportGroupId))
+		}


This function still returns a DuplicateEntryDatabaseError on duplicate relations. Per the PR/issue goal (“don't throw error when adding existing relations”), this should be treated as a no-op and return nil instead (or the higher layers will continue logging an error for duplicates).

Copilot · 2026-03-20T13:48:56Z

internal/database/mariadb/support_group.go

+	if err != nil {
+		if strings.HasPrefix(err.Error(), "Error 1062") {
+			return database.NewDuplicateEntryDatabaseError(fmt.Sprintf("User %d already in SupportGroup %d", userId, supportGroupId))
+		}


This function still returns a DuplicateEntryDatabaseError on duplicate relations. Per the PR/issue goal (“don't throw error when adding existing relations”), this should be treated as a no-op and return nil instead (or the higher layers will continue logging an error for duplicates).

Copilot · 2026-03-20T13:48:56Z

internal/database/mariadb/service.go

+	if err != nil {
+		if strings.HasPrefix(err.Error(), "Error 1062") {
+			return database.NewDuplicateEntryDatabaseError(fmt.Sprintf("User %d already an owner of Service %d", userId, serviceId))
+		}


This function still returns a DuplicateEntryDatabaseError on duplicate relations. Per the PR/issue goal (“don't throw error when adding existing relations”), duplicates should be treated as a no-op and return nil here (otherwise callers will continue to handle/log it as an error).

Aliexe-code requested review from MR2011, copyonwrite, dorneanu, drochow and michalkrzyz as code owners February 5, 2026 11:05

michalkrzyz requested changes Feb 5, 2026

View reviewed changes

refactor:don't throw error when adding existing relations

0fe7000

If the relation already exists, don't throw an error message. This prevents polluting logs with duplicate entry errors Fixes cloudoperators#1057

Aliexe-code force-pushed the fix/1057-existing-relations branch from 543078c to 0fe7000 Compare February 5, 2026 19:11

MR2011 reviewed Feb 6, 2026

View reviewed changes

refactor: use errors.As() for MySQL duplicate entry detection

3d56902

Replace strings.Contains() with errors.As() for more robust MySQL error handling when detecting duplicate entry errors (error code 1062). Addresses reviewer feedback from cloudoperators#1076

Aliexe-code requested a review from michalkrzyz February 10, 2026 05:09

Merge branch 'main' into fix/1057-existing-relations

e89f75a

Copilot AI review requested due to automatic review settings March 20, 2026 13:46

Copilot started reviewing on behalf of MR2011 March 20, 2026 13:46 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor:don't throw error when adding existing relations#1076

refactor:don't throw error when adding existing relations#1076
Aliexe-code wants to merge 4 commits intocloudoperators:mainfrom
Aliexe-code:fix/1057-existing-relations

Aliexe-code commented Feb 5, 2026

Uh oh!

michalkrzyz Feb 5, 2026

Uh oh!

MR2011 Feb 6, 2026

Uh oh!

MR2011 Feb 6, 2026

Uh oh!

MR2011 commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Aliexe-code commented Feb 5, 2026

Uh oh!

michalkrzyz Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

MR2011 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

MR2011 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

MR2011 commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants