Replace dynamodb scan with query#31
Open
Igor Rodionov (goruha) wants to merge 12 commits intomainfrom
Open
Conversation
Igor Rodionov (goruha)
requested review from
Hans Donner (hans-d) and
Kevin (kevcube)
…sse/github-action-terraform-plan-storage into replace-dynamodb-scan-with-query * 'replace-dynamodb-scan-with-query' of github.com:cloudposse/github-action-terraform-plan-storage: Update contents of the dist directory
Igor Rodionov (goruha)
added
the
major
Erik Osterman (CEO @ Cloud Posse) (osterman)
previously approved these changes
Jun 12, 2024
Igor Rodionov (goruha)
added
the
do not merge
Matt Calhoun (mcalhoun)
suggested changes
Sep 19, 2024
| KeyConditionExpression: "#commitSHA= :commitSHA", | ||
| FilterExpression: | ||
| "#owner = :owner and #repo = :repo and #commitSHA = :commitSHA and #component = :component and #stack = :stack", | ||
| "#owner = :owner and #repo = :repo and #component = :component and #stack = :stack", |
Contributor
There was a problem hiding this comment.
Why are we removing the condition to match the commit SHA? I don't see how this could be correct?
Member
Author
There was a problem hiding this comment.
Matt Calhoun (@mcalhoun) because we filter sha with KeyCondition
https://github.com/cloudposse/github-action-terraform-plan-storage/pull/31/files#diff-95366d8215594fbafa600c4d01acd3040d43de241933dcf7a6ad86ead80e391aR33
KeyConditionExpression: "#commitSHA= :commitSHA",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
DynamoDBscanwithquerywhy
If the total size of scanned items exceeds the maximum dataset size limit of 1 MB, the scan completes and results are returned to the user. The LastEvaluatedKey value is also returned and the requestor can use the LastEvaluatedKey to continue the scan in a subsequent operation.queryis cheaper thenscanfalse negativesget plan casesreferences
Migration