-
Notifications
You must be signed in to change notification settings - Fork 205
feat: Replace date-fns with dayjs #3786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3786 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 856 856
Lines 25241 25276 +35
Branches 8939 8969 +30
=======================================
+ Hits 24527 24562 +35
- Misses 665 708 +43
+ Partials 49 6 -43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9c8d018 to
42a8166
Compare
|
Hi @TrevorBurnham , There is one failing unit test: |
|
@pan-kot Thanks! I've updated this branch. |
|
There are integration tests failing with: |
|
@pan-kot I've updated and rebased the branch. I've tried to address the integration test issue, but I'm unable to run those tests on my machine, so please kick off the CI build to verify the fix. |
|
I saw that the CI failed because the chart-components package has an implicit dependency on |
This PR replaces the date-fns dependency with dayjs, a more lightweight alternative.
Description
This PR replaces the date-fns dependency with dayjs, a more lightweight alternative. This should not affect any functionality. The intent is purely to reduce bundle size and, secondarily,
node_modulesweight.Estimated performance impact
For a production site that doesn't use
date-fnsoutside of Cloudscape, this change should reduce the size of the minified JavaScript bundle by ~40 KB, enough to improve page load times by ~10ms for a typical user.How has this been tested?
All unit tests are passing. I haven't been able to run the integration tests on my machine, so please let me know if there are any issues with those.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.