Skip to content

Conversation

@TrevorBurnham
Copy link
Contributor

@TrevorBurnham TrevorBurnham commented Nov 1, 2025

Description

We're unable to upgrade to the latest versions of react-keyed-flatten-children because of how it's packaged: We have Jest customers that are allergic to ESM. So we're stuck on an old version.

From #3080:

It is such a small utility that sometimes I wonder if it's worth inlining into the package…

This PR does exactly that: It adds the dep (specifically, react-keyed-flatten-children@3.2.0 to our vendor/ dir and adds an appropriate peer dependency on react-is. That peer dependency should be a significant efficiency improvement for many of our customers: The version of react-keyed-flatten-children we were using depended on react-is@^18.2.0, which meant that customers with any higher or lower version of react-is would wind up with two copies of that dependency in their bundle.

How has this been tested?

All unit tests pass.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@TrevorBurnham TrevorBurnham requested a review from a team as a code owner November 1, 2025 04:10
@TrevorBurnham TrevorBurnham requested review from georgylobko and removed request for a team November 1, 2025 04:10
@TrevorBurnham TrevorBurnham force-pushed the react-keyed-flatten-children-inline branch 2 times, most recently from df8fc4d to e479d04 Compare January 2, 2026 14:19
@TrevorBurnham TrevorBurnham force-pushed the react-keyed-flatten-children-inline branch from e479d04 to 62c7faf Compare January 2, 2026 14:48
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (8daa3af) to head (62c7faf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3997   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         873      873           
  Lines       25562    25562           
  Branches     9240     9240           
=======================================
  Hits        24830    24830           
  Misses        685      685           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants